-
Notifications
You must be signed in to change notification settings - Fork 264
fix(stdio): add stdin close/end listeners to prevent zombie/orphan processes #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ElliotDrel
wants to merge
19
commits into
punkpeye:main
Choose a base branch
from
ElliotDrel:fix/stdin-close-zombie-process
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
59f1e9f
fix(stdio): add stdin close/end listeners to prevent zombie processes
ElliotDrel a7dc3bb
style: run prettier on FastMCP.ts
ElliotDrel 27e5d4b
fix: address Copilot review — idempotency, listener cleanup, and stdi…
ElliotDrel 8ee2261
fix: resolve ESLint sort-objects and no-unused-vars in stdio test
ElliotDrel 46b8c62
fix(lint): remove unused params from stdinOffSpy mockImplementation
ElliotDrel 9863deb
fix(lint): apply prettier formatting to stdio test file
ElliotDrel d190692
fix(test): hoist vi.mock to module level to fix Vitest hoisting issue
ElliotDrel 7b995fb
fix(test): use fake timers to skip FastMCPSession capability retry loop
ElliotDrel b643fe9
fix(test): use regular function in vi.fn mock so new StdioServerTrans…
ElliotDrel 80e614d
test: add integration test for stdin-close zombie prevention
ElliotDrel 9edc18c
style: fix prettier formatting in stdio integration test
ElliotDrel 838b14e
fix(lint): fix perfectionist ordering in stdio integration test
ElliotDrel 5350f15
fix(test): increase timeout for tsx cold-download in CI (60s ready, 9…
ElliotDrel 2f7f8b8
fix(test): add tsx devDep, use installed binary instead of npx cold-d…
ElliotDrel a4b43d3
fix: update pnpm-lock.yaml after adding tsx devDependency
ElliotDrel 2f7750a
fix(test): use temp .ts file instead of --eval so ESM imports resolve…
ElliotDrel e8d8f58
style: fix prettier formatting in integration test
ElliotDrel 258b9d1
fix(lint): sort named imports, add comment to empty catch blocks
ElliotDrel 582d869
revert: remove integration test and tsx devDep
ElliotDrel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.