Add PACE and several bug fixes into Gwaihir branch - #1
reviewdog [verible-verilog-lint] report
reported by reviewdog 🐶
Findings (9)
hw/src/spatz_vlsu.sv|789 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/src/spatz_vlsu.sv|799 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/src/spatz_vlsu.sv|809 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/src/generated/spatz_pkg.sv|21 col 27| Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9]*)+(_[0-9]+)?) [Style: constants] [parameter-name-style]
hw/src/pace_mem.sv|51 col 14| Explicitly define a storage type for every parameter and localparam, (NumParamWords). [Style: constants] [explicit-parameter-storage-type]
hw/src/pace_mem.sv|52 col 14| Explicitly define a storage type for every parameter and localparam, (RemParamWords). [Style: constants] [explicit-parameter-storage-type]
hw/src/pace_mem.sv|54 col 25| All generate block statements must have a label [Style: generate-statements] [generate-label]
hw/src/pace_mem.sv|55 col 46| All generate block statements must have a label [Style: generate-statements] [generate-label]
hw/src/pace_mem.sv|59 col 25| All generate block statements must have a label [Style: generate-statements] [generate-label]
Filtered Findings (0)
Annotations
Check warning on line 789 in hw/src/spatz_vlsu.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/src/spatz_vlsu.sv#L789
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/src/spatz_vlsu.sv" range:{start:{line:789 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:789 column:1} end:{line:790}} text:"\n"}
Check warning on line 799 in hw/src/spatz_vlsu.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/src/spatz_vlsu.sv#L799
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/src/spatz_vlsu.sv" range:{start:{line:799 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:799 column:1} end:{line:800}} text:"\n"}
Check warning on line 809 in hw/src/spatz_vlsu.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/src/spatz_vlsu.sv#L809
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/src/spatz_vlsu.sv" range:{start:{line:809 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:809 column:1} end:{line:810}} text:"\n"}
Check warning on line 21 in hw/src/generated/spatz_pkg.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/src/generated/spatz_pkg.sv#L21
Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9]*)+(_[0-9]+)?) [Style: constants] [parameter-name-style]
Raw output
message:"Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9]*)+(_[0-9]+)?) [Style: constants] [parameter-name-style]" location:{path:"hw/src/generated/spatz_pkg.sv" range:{start:{line:21 column:27}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"}
Check warning on line 51 in hw/src/pace_mem.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/src/pace_mem.sv#L51
Explicitly define a storage type for every parameter and localparam, (NumParamWords). [Style: constants] [explicit-parameter-storage-type]
Raw output
message:"Explicitly define a storage type for every parameter and localparam, (NumParamWords). [Style: constants] [explicit-parameter-storage-type]" location:{path:"hw/src/pace_mem.sv" range:{start:{line:51 column:14}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"}
Check warning on line 52 in hw/src/pace_mem.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/src/pace_mem.sv#L52
Explicitly define a storage type for every parameter and localparam, (RemParamWords). [Style: constants] [explicit-parameter-storage-type]
Raw output
message:"Explicitly define a storage type for every parameter and localparam, (RemParamWords). [Style: constants] [explicit-parameter-storage-type]" location:{path:"hw/src/pace_mem.sv" range:{start:{line:52 column:14}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"}
Check warning on line 54 in hw/src/pace_mem.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/src/pace_mem.sv#L54
All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]" location:{path:"hw/src/pace_mem.sv" range:{start:{line:54 column:25}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"}
Check warning on line 55 in hw/src/pace_mem.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/src/pace_mem.sv#L55
All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]" location:{path:"hw/src/pace_mem.sv" range:{start:{line:55 column:46}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"}
Check warning on line 59 in hw/src/pace_mem.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/src/pace_mem.sv#L59
All generate block statements must have a label [Style: generate-statements] [generate-label]
Raw output
message:"All generate block statements must have a label [Style: generate-statements] [generate-label]" location:{path:"hw/src/pace_mem.sv" range:{start:{line:59 column:25}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"}