[Atop Filter] Add an obi_atop_filter module to filter-out atomic requests#44
Open
LucaRufer wants to merge 1 commit into
Open
[Atop Filter] Add an obi_atop_filter module to filter-out atomic requests#44LucaRufer wants to merge 1 commit into
LucaRufer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an
obi_atop_filtermodule that filters-out atomic requests and responds with an error. The module was created as suggested in #15.Motivation
This module was created as a counter-part to the
obi_atop_resolver, which resolves OBI requests. With these two modules, a user can combine a bus with atomics support to a bus without atomics support and choose whether to resolve or block atomic transactions - allowing selective mixed atomicity systems.Implementation details
The new module filters atomic operations (ATOPs), i.e., write transactions that have a non-zero
a.atopvalue, from its subordinate to its manager port. The module guarantees that:a.atopis alwaysobi_pkg::ATOPNONEon themgrport;a.atopon thesbrport are handled in conformance with the OBI standard by replying to such transactions with{err, exokay} = 2’b10.The module supports a configurable number of outstanding transactions.
When an atomic request is detected, the module behaves as follows:
The module supports all currently possible OBI configurations, with the exception of Integrity.
In addition to the module, a testbench was added to verify the module. The testbench requires #43 to work properly.