[Testing] Add missing 'err' signal to obi_test#40
Merged
Conversation
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
errsignal to theobi_driverclass. The signal was present in the interface, but never driven by the driver. Additionally, it is added to thesend_rtask of the driver, as all the other reponse phase signals are.As for the value the random subordinate generates for the
errsignal when callingsend_r, the approach fromaxi_testwas used and a new parameter of the random subordinate calledRandRespis used to determine if theerrsignal is randomized or always0(default for compatibility with other testbenches).