Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

Added workaround for incorrect null dereference warnings in GCC 11.1.0#15

Open
TobiasFaller wants to merge 2 commits into
pulp-platform:masterfrom
TobiasFaller:fix-workaround-nonnull-warning-gcc-11
Open

Added workaround for incorrect null dereference warnings in GCC 11.1.0#15
TobiasFaller wants to merge 2 commits into
pulp-platform:masterfrom
TobiasFaller:fix-workaround-nonnull-warning-gcc-11

Conversation

@TobiasFaller

@TobiasFaller TobiasFaller commented Jul 1, 2021

Copy link
Copy Markdown

This pull request provides a workaround for the fatal build error described in pulp-platform/pulp-sdk#102 by decreasing the severity of the warning.

@bluewww

bluewww commented Jul 4, 2021

Copy link
Copy Markdown

Actually I think we can just add this flag by default. No need to gate it behind this flag

@TobiasFaller

TobiasFaller commented Jul 4, 2021

Copy link
Copy Markdown
Author

@bluewww Changed workaround to be enabled by default. In this case the merge request pulp-platform/pulpissimo#263 can be reverted and I will close pulp-platform/pulp-sdk#103.

@bluewww bluewww left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TobiasFaller

Copy link
Copy Markdown
Author

@haugoug Will this fix be merged at some point?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants