fix: avoid repeated service inspection in list and deploy#355
Open
nick-potts wants to merge 9 commits into
Open
fix: avoid repeated service inspection in list and deploy#355nick-potts wants to merge 9 commits into
nick-potts wants to merge 9 commits into
Conversation
nick-potts
force-pushed
the
feat/n1-improvements
branch
2 times, most recently
from
5f4ea6a to
0e389ef
Compare
nick-potts
force-pushed
the
feat/n1-improvements
branch
from
961638f to
9835ed6
Compare
nick-potts
force-pushed
the
feat/n1-improvements
branch
from
9835ed6 to
4cb9104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids doing per-service inspection when you can do a single read.
uc service lsnow builds services from the broadcast container response instead of calling inspect for every service.For other read/planning paths this adds a small request scoped cluster snapshot. The snapshot is only used where we are already doing batch read work: logs, image listing, and compose deploy planning. Mutating paths still use the existing fresh reads.
Compose deploy planning now reuses the current service list and domain resolver across all services in the compose file.