add support for service.labels and deploy.labels#245
Open
nick-potts wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
I believe deploy labels like this is a good choice and somewhat mirrors swarm. You can then use something like deployment_id under a deploy label, and it won't require re-creating a stateful resource like postgres. Annoyingly in Swarm, deploy.labels are "service labels" (metadata on the service itself), while service.labels are actually "container labels" (applied to containers) and is quite confusing. Maybe its worth considering whether the ServiceSpec field names could be more explicit - e.g., ContainerLabels vs ServiceLabels to avoid the same confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two label types with different update semantics:
User labels cannot override uncloud.* prefixed labels.
CLI