Fix missing serde "derive" feature#798
Open
edgarogh wants to merge 5 commits into
Open
Conversation
Author
|
(to reproduce the issue, just create a blank crate with just |
edgarogh
force-pushed
the
fix-missing-serde-derive
branch
from
50f8215 to
6948798
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
auto-merge was automatically disabled
March 13, 2025 04:07
Rebase failed
auto-merge was automatically disabled
March 13, 2025 08:26
Rebase failed
auto-merge was automatically disabled
March 24, 2025 07:42
Rebase failed
auto-merge was automatically disabled
March 27, 2025 23:28
Rebase failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when used as a dependency on another project,
serde-sarifdoesn't compile because it uses serde's derive macros internally but doesn't enablefeatures = ["derive"].The local builds work only by chance, because
schemafy_coredoes enablederive, but it is a dev-dependency. You can verify this withcargo tree -e features -i serde --package serde-sarifwhich shows which crates are responsible for enabling each of serde's features.This 1-line PR just enable the feature.