Cherry pick 0.32.3 - #5366
Merged
Spaceman1701 merged 5 commits intoJul 4, 2026
Merged
Conversation
Signed-off-by: Ethan Hunter <ehunter@hudson-trading.com>
…theus#5330) Signed-off-by: Ethan Hunter <ehunter@hudson-trading.com>
GettableSilenceFromProto left the Matchers field as a nil slice when a silence had no matcher sets, only ever populating it via append. Go's encoding/json marshals a nil slice as null, so such silences were serialized as "matchers": null. The OpenAPI schema declares matchers as a required array, so an empty silence should serialize as [] instead. Initialize Matchers to an empty slice so the field is always a valid JSON array, keeping the v2 API schema-compliant for matcher-less silences. Related to prometheus#5326 Signed-off-by: Siavash Safi <siavash@cloudflare.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
siavashs
approved these changes
Jul 3, 2026
2 tasks
Signed-off-by: Ethan Hunter <ehunter@hudson-trading.com>
Signed-off-by: Ethan Hunter <ehunter@hudson-trading.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry picks the changes in #5364 into
release-0.32