Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/matter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:

strategy:
matrix:
node-version: [20.x]
node-version: [24.x]
os: [ubuntu-22.04]

steps:
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
- name: Install Node.js, NPM and Yarn
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 24.x
cache: 'npm'

- name: Prepare Linux build environment
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [20.x]
node-version: [24.x]
os: [ubuntu-22.04]

steps:
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [20.x]
node-version: [24.x]
os: [ubuntu-22.04]

steps:
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:

strategy:
matrix:
node-version: [20.x]
node-version: [24.x]
os: [ubuntu-22.04]

steps:
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:

strategy:
matrix:
node-version: [20.x]
node-version: [24.x]
os: [ubuntu-22.04]

steps:
Expand Down Expand Up @@ -178,7 +178,7 @@ jobs:
- name: Install Node.js, NPM and Yarn
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 24.x
cache: 'npm'
- name: pip
run: pip install setuptools
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/zigbee.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:

strategy:
matrix:
node-version: [20.x]
node-version: [24.x]
os: [ubuntu-22.04]

steps:
Expand Down
7 changes: 3 additions & 4 deletions babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,9 @@ module.exports = (api) => {
'@babel/preset-typescript'
],
plugins: [
// Add Istanbul plugin for code coverage instrumentation when testing
process.env.NODE_ENV === 'test' && 'istanbul',
// Add coverage plugin for Cypress
process.env.CYPRESS_COVERAGE && 'istanbul'
// Istanbul once: e2e sets NODE_ENV=test and CYPRESS_COVERAGE together (duplicate plugin breaks Babel)
(process.env.NODE_ENV === 'test' || process.env.CYPRESS_COVERAGE) &&
'istanbul'
].filter(Boolean)
}
}
2 changes: 1 addition & 1 deletion docs/development-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This section lists instructions for various things you might need to do in this repo.

This is a node.js application, so you need node environment installed. The best way is to simply download latest install of [node](https://nodejs.org/en/download/) and you will get node and npm. If you have an older version of node installed on your workstation, it may give you trouble, particularly if it's very old. So make sure you have latest node v16.x, v18.x or v20.x version, with the npm that comes with it available. Run `node --version` to check what version is picked up. v20.x is recommended.
This is a node.js application, so you need node environment installed. The best way is to simply download latest install of [node](https://nodejs.org/en/download/) and you will get node and npm. If you have an older version of node installed on your workstation, it may give you trouble, particularly if it's very old. For building the Electron UI and running the same toolchain as CI, use **Node.js v24.0 or newer** (GitHub Actions uses `24.x`). Older versions may still run parts of the stack but can show `EBADENGINE` warnings for `@electron/rebuild` and related packages. Run `node --version` to check what version is picked up.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The documentation recommends Node.js v24.0 or newer, which contradicts the PR title ("Node 22 CI") and the description ("CI: use Node.js 22.x"). This should be updated to align with the actual supported Node version for the project to avoid confusing contributors.


Once you have a desired version of node, you can run:

Expand Down
2 changes: 1 addition & 1 deletion docs/faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ References:
To fix this in most cases, run:

- `npm install`
- `./node_modules/.bin/electron-rebuild -w sqlite3 -p`
- `npx electron-rebuild -w sqlite3 -p` (from devDependency `@electron/rebuild`)

If it still doesn't get fixed, do:

Expand Down
Loading
Loading