Test against @prisma/dev 0.25.2, which recovers from a crashed holder - #261
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0.25.2 fixes the false "already running" refusal after a server owner died without releasing its lock (prisma/team-expansion#2110). Composer loads the app's installed @prisma/dev at runtime, so this only moves the devDependency our own emulator tests run against. Verified locally: a start-SIGKILL-restart cycle now comes back in under a second, and both dev-emulators and local-target suites pass. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
wmadden-electric
force-pushed
the
claude/prisma-dev-stale-lock-601c0e
branch
from
August 25, 2026 13:10
271e1e3 to
5578952
Compare
commit: |
wmadden
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
@prisma/devdevDependency in@internal/dev-emulatorsand@internal/local-targetfrom^0.24.14to^0.25.2and refreshes the lockfile.0.25.2 fixes the false "already running" refusal after a server owner died without releasing its lock (prisma/team-expansion#2110): the start path now runs the same liveness chain the status path uses and breaks a provably dead holder's lock. Composer loads the app's installed
@prisma/devat runtime, so users get the fix from their app'sprismaversion — this bump only changes what composer's own emulator tests exercise.Verified locally against 0.25.2:
@internal/dev-emulators(67 tests) and@internal/local-target(15 tests) suites pass.One flake surfaced during verification was environmental, not 0.25.2: a stale garbage record in the local
prisma-dev-nodejsdata directory (all ports recorded as 3000) madestartPrismaDevServerhang in any version; removing it cleared the failure.🤖 Generated with Claude Code