New Adapter: ReVantage#4477
Open
v0idxyz wants to merge 6 commits into
Open
Conversation
CTMBNara
requested changes
May 13, 2026
Removed detailed class-level documentation and some comments in the makeHttpRequests method.
bukrain
reviewed
May 19, 2026
Comment on lines
+131
to
+141
| public void makeBidsShouldReturnEmptyListOn204() throws Exception { | ||
| // given | ||
| final BidderCall<BidRequest> httpCall = givenHttpCall(204, null); | ||
|
|
||
| // when | ||
| final Result<List<BidderBid>> result = target.makeBids(httpCall, BidRequest.builder().build()); | ||
|
|
||
| // then | ||
| assertThat(result.getErrors()).isEmpty(); | ||
| assertThat(result.getValue()).isEmpty(); | ||
| } |
Collaborator
There was a problem hiding this comment.
As null is expected in the body, maybe it would make sense to first check if it's not null, since this test, doesn't seem to pass.
Also can the body of the response be null when makeBids is called? Would expect for it to be an empty string "".
@CTMBNara what do you think?
| } | ||
|
|
||
| @Test | ||
| public void makeBidsShouldDetectVideoFromVastWhenMtypeAbsent() throws Exception { |
Collaborator
There was a problem hiding this comment.
nitpick
I would suggest to add a test cases for the adm that starts with <?XML and also for the case that adm is empty that it would be marked as an mtype of banner.
Removed validation annotation from configuration properties bean.
Author
|
Please let me know if anything else has been missed or if we're good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check