Skip to content

Doc: add category for loadflow parameters - #3999

Merged
colineplqt merged 4 commits into
mainfrom
doc-lf-param
Aug 4, 2026
Merged

Doc: add category for loadflow parameters#3999
colineplqt merged 4 commits into
mainfrom
doc-lf-param

Conversation

@alicecaron

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

No.

What kind of change does this PR introduce?

Add documentation, classify loadflow parameters in categories to clarify parameter usages. It is purely indicationnal, no real categories are created within the code.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: CARON Alice <alice.caron@rte-france.com>
@alicecaron

Copy link
Copy Markdown
Contributor Author

Related to the open loadflow documentation modification also to be coherent olf#1470 with the lf parameter categories

@alicecaron
alicecaron requested a review from colineplqt July 24, 2026 08:43
@alicecaron alicecaron moved this from TODO to Waiting for review in Release 09/2026 Jul 24, 2026

@colineplqt colineplqt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark. I guess you have ordered the sections alphabetically but I think it's a bit odd in the documentation to start with DC and debug which are not the main parameters that people would be interested in I am guessing.

I would suggest more something like that:

Model
Voltage Initialization
DC
HVDC
Voltage Control
Shunt Voltage Control
Phase Control
Transformer Voltage Control
Slack Distribution
Performance
Debug

or maybe following the steps of the load flow?

Comment thread docs/simulation/loadflow/configuration.md Outdated
Comment thread docs/simulation/loadflow/configuration.md
Signed-off-by: CARON Alice <alice.caron@rte-france.com>
@alicecaron

Copy link
Copy Markdown
Contributor Author

One remark. I guess you have ordered the sections alphabetically but I think it's a bit odd in the documentation to start with DC and debug which are not the main parameters that people would be interested in I am guessing.

I would suggest more something like that:

Model Voltage Initialization DC HVDC Voltage Control Shunt Voltage Control Phase Control Transformer Voltage Control Slack Distribution Performance Debug

or maybe following the steps of the load flow?

I agree it could have more sense to order the section with a more user centered interest order.

This was indeed alphabetically done to be coherent with the logs that are displayed when running the loadflow.

So if we change this in the documentation maybe we also need to change the sorting for the category displaying in open loadflow (in OpenLoadFlowParameters::log the only known public implementation for now).

What do you think @SylvestreSakti ?

@SylvestreSakti

Copy link
Copy Markdown
Member

One remark. I guess you have ordered the sections alphabetically but I think it's a bit odd in the documentation to start with DC and debug which are not the main parameters that people would be interested in I am guessing.
I would suggest more something like that:
Model Voltage Initialization DC HVDC Voltage Control Shunt Voltage Control Phase Control Transformer Voltage Control Slack Distribution Performance Debug
or maybe following the steps of the load flow?

I agree it could have more sense to order the section with a more user centered interest order.

This was indeed alphabetically done to be coherent with the logs that are displayed when running the loadflow.

So if we change this in the documentation maybe we also need to change the sorting for the category displaying in open loadflow (in OpenLoadFlowParameters::log the only known public implementation for now).

What do you think @SylvestreSakti ?

Hello, I agree with Coline on the order of the categories. For the documentation, it seems more necessary than for the logs so no need to change the parameters logging I thing

Signed-off-by: CARON Alice <alice.caron@rte-france.com>
@alicecaron

Copy link
Copy Markdown
Contributor Author

One remark. I guess you have ordered the sections alphabetically but I think it's a bit odd in the documentation to start with DC and debug which are not the main parameters that people would be interested in I am guessing.

I would suggest more something like that:

Model Voltage Initialization DC HVDC Voltage Control Shunt Voltage Control Phase Control Transformer Voltage Control Slack Distribution Performance Debug

or maybe following the steps of the load flow?

done!

@alicecaron
alicecaron requested a review from colineplqt August 4, 2026 14:11

@colineplqt colineplqt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-project-automation github-project-automation Bot moved this from Waiting for review to Approved in Release 09/2026 Aug 4, 2026
@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

@colineplqt
colineplqt merged commit 4e8024e into main Aug 4, 2026
9 checks passed
@colineplqt
colineplqt deleted the doc-lf-param branch August 4, 2026 15:55
@github-project-automation github-project-automation Bot moved this from Approved to Done in Release 09/2026 Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants