FP is part of the execution state, alongside PC.#3776
Draft
lvella wants to merge 4 commits into
Draft
Conversation
powdr-openvm relies on the forked openvm where `fp` is a first-class ExecutionState field (VmStateMut/PhantomSubExecutor carry `fp`). Move the openvm git dependencies from tag v2.0.0-beta.2-powdr.1 to branch first-class-fp so the patched powdr sources compile against the fork and consumers don't pull two conflicting copies of openvm-circuit-primitives. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
OpenVM's execution state no longer has a dedicated `fp` field; the frame pointer is carried in `extra_regs[0]` (see openvm `EXTRA_EXEC_REGS`). - powdr_extension executor: destructure/reconstruct `VmStateMut` with `extra_regs` instead of `fp`. - hints-circuit phantom sub-executors: `phantom_execute` takes `extra_regs: [u32; EXTRA_EXEC_REGS]` instead of `fp: u32`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.