fix(isa-utils): escape control characters in quoted strings#3772
Open
pengqima wants to merge 1 commit into
Open
fix(isa-utils): escape control characters in quoted strings#3772pengqima wants to merge 1 commit into
pengqima wants to merge 1 commit into
Conversation
Signed-off-by: pengqima <pengqima@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
powdr_isa_utils::quotepreviously escaped backslashes and double quotes, but left control characters such as newlines, carriage returns, and tabs unchanged. That could produce quoted strings containing raw control characters instead of escaped sequences.This change extends
quoteto emit escaped forms for common control characters and unicode-style escapes for other control characters. It also adds a regression test for newline, tab, and carriage return escaping.Testing
cargo fmt --check -p powdr-isa-utilsgit diff --checkrustc --edition=2021 --test isa-utils/src/lib.rsand ranquote_escapes_control_characters