Change baseurl from '/' to '' as per Jekyll norm#93
Closed
jonbartlett wants to merge 2 commits into
Closed
Conversation
|
👍 |
|
👍 |
|
Any update on this? I've noticed this as well in my sitemap.xml file after forking hyde. |
jessdarneswrites
pushed a commit
to jessdarneswrites/jessdarneswrites.github.io
that referenced
this pull request
Jul 16, 2015
johnowl
added a commit
to johnowl/johnowl.github.io
that referenced
this pull request
Feb 3, 2017
joanasouza
pushed a commit
to joanasouza/joanasouza.github.io
that referenced
this pull request
Jan 8, 2018
Enable pinch zooming on mobile devices
Member
|
Fix coming in #258. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been trying to use Jekyll Sitemap against my Hyde based site and have faced issues with this line of code in
_config.yml:baseurl: /The problem is that Jekyll Sitemap creates
sitemap.xmlfile with incorrect urls (note the double//):Looking around at other Jekyll sites the
baseurlis set to''in most cases. The Lanyon theme is configured like this.Also when running
jekyll servethis fires up onServer address: http://127.0.0.1:4000//. Note the trailing slash.Pull request addresses these issues by modifying
_config.ymland updating files that referencebaseurl.