Fix update_symbol_addrs.py compatibility#1262
Conversation
|
Thanks for working on this. my preference would be that we use mapfile_parser instead, as it has pretty much already solved the problem being attempted in this script. I was meaning to update it at some point, but I never got around to it..would you be willing to modify the script to use it instead? |
|
Sure thing. I'll take a look through it and see how I can rework the script. |
|
I've changed the mapfile parsing to use We don't output any of the additional info |
The old version of the script does a lot of manual parsing with hardcoded offsets into lines and so on, which no longer works due to both modifications made to the relevant files since the script's creation, and the fact these offsets can vary between versions.
This PR changes a few things:
python tools/update_symbol_addrs.py jpto specify a version to work with instead ofcurrent.I have not committed the actual update
symbol_addrs.txtfiles because the script, being automatic, removes all of the manually authored comments, but the updated script runs for all supported versions and I can add them in if desired.