ch4/ofi: Always process window accumulate hints#7807
Open
raffenet wants to merge 1 commit into
Open
Conversation
MPI_WIN_CREATE_DYNAMIC may attempt to register the whole virtual address space. When this fails, win_allgather exits early and skips over load_acc_hints. Later, after a collective MPI_WIN_ATTACH, processes may attempt accumulate operations. This results in a crash when querying the ops supported since the hints were never processed. Always load the hints since it is a local operation on the control path (window construction). This was code can always safely access them later.
Contributor
|
test:mpich/ch4/most |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
MPI_WIN_CREATE_DYNAMIC may attempt to register the whole virtual address space. When this fails, win_allgather exits early and skips over load_acc_hints. Later, after a collective MPI_WIN_ATTACH, processes may attempt accumulate operations. This results in a crash when querying the ops supported since the hints were never processed.
Always load the hints since it is a local operation on the control path (window construction). This was code can always safely access them later.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.