ch4/xpmem: Support disabling mapped segment cache#7349
Open
raffenet wants to merge 7 commits into
Open
Conversation
We use this CVAR to control the initialization of XPMEM, so move it where it is most appropriate.
Contributor
Author
|
test:mpich/ch4/xpmem |
added 3 commits
March 19, 2025 15:28
Use initialized state when deciding whether to use XPMEM. Avoid overwriting the value MPIR_CVAR_CH4_XPMEM_ENABLE, which could be modified during runtime by MPI_T.
Make init and finalize symmetrical. Avoid calling GAVL utilities directly in finalize.
These functions are closely related. Combine them in a single file for ease of maintenance. Make segment register and free private static functions.
raffenet
force-pushed
the
xpmem-changes
branch
2 times, most recently
from
b13e589 to
663255c
Compare
Contributor
Author
|
test:mpich/ch4/most |
Contributor
Author
|
test:mpich/ch4/most |
Contributor
Author
|
test:mpich/ch4/most |
Contributor
Author
|
test:mpich/ch4/most |
added 3 commits
March 20, 2025 12:05
Implement search and insert functions for mapped cache segments. These will be used by the handle mapping function, and will make for easier targets when adding the ability to disable the segment cache.
There may situations where disabling the mapped segment cache is desirable. Allow a way to control usage at runtime.
When the mapped segment cache is disabled, unmap segments once we are done copying from them. Since we need access to the actual attached address, we store it in the handle during mapping. To achieve this, we pass the handle to map/unmap by reference rather than value to allow modification of its contents.
Contributor
Author
|
test:mpich/ch4/most |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Cleanup and refactor portions of the XPMEM code to support disabling the mapped segment cache. The goal is to aid experimentation on systems with XPMEM to better understand the impact of the cache on application performance.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.