Add workflow for uploading dev builds of Plotly.js #7795
Conversation
|
@camdecoster FYI there are no major changes to the contents of the |
| @@ -1,17 +1,117 @@ | |||
| name: Upload dev build from PR (placeholder, not yet implemented) | |||
There was a problem hiding this comment.
| name: Upload dev build from PR |
There was a problem hiding this comment.
Because of the (silly) way GHA woks, changing this title will break the link between this workflow file and the version on master. I'll update the title immediately before merging.
There was a problem hiding this comment.
have not forgotten about this, I will update before merging
|
@camdecoster Following up on one of our previous discussions, GitHub Pages has a total size limit of 1 GB. That works out to about ~50 separate dev builds (1000 MB / 20 MB = 50). A little lower than I was hoping, but if that turns out not to be enough, we can decrease the retention time and/or save only the latest build for each PR rather than individual copies per commit. I suppose another option is to retain only |
Closes #7759
upload-dev-build.ymlworkflow which uploads a development build of plotly.js every time a new commit is pushed to a PRhttps://plotly.github.io/plotly.js-dev-builds/upload/pr-{PR_NUM}/latest/plotly.min.js(for the latest commit on a PR)https://plotly.github.io/plotly.js-dev-builds/upload/pr-{PR_NUM}/{SHA}/plotly.min.js(for a specific commit SHA on a PR)*/plotly.jsand*/plot-schema.jsonalso workpublish-distjobs into a separatepublish-dist.ymlworkflow, so that theupload-dev-buildworkflow can be triggered as soon aspublish-distfinishes, without waiting for all the tests to completeSteps for testing
workflow_runtrigger always runs the version of the workflow on the default branch. This is an important security feature, but it meansworkflow_runwon't allow us to test this implementationpersistent-dev-build-url-2(this branch)7795(this PR) and Run ID25766159639(a completed run of thepublish-distworkflow for this PR)