fix(review): a mouse click no longer pins a card's reply bar open - #137
Merged
Samuel Lawerence (samuellawerentz) merged 1 commit intoAug 7, 2026
Merged
Conversation
Clicking a thread card's anchor chip parked plain :focus on the button, and group-focus-within kept the reply bar expanded after hover-out. The next mousedown anywhere else blurred it, collapsed the row between that click's mousedown and mouseup, and the shifted target meant the click never fired — clicking a lower card's anchor did nothing while the rail jumped up. Expansion now keys on :focus-visible: tabbing into a card still opens the reply bar (the reason focus-within was there), but a mouse click does not pin it, so the collapse happens on hover-out while the pointer travels and layout is settled before the next click lands. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011iMXVvMG1u9VwWwYqLp4Gm
Samuel Lawerence (samuellawerentz)
deleted the
fix/thread-card-reply-collapse
branch
August 7, 2026 08:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking a thread card's anchor chip left plain
:focuson the button, andgroup-focus-withinkept that card's reply bar expanded after hover-out. The next mousedown anywhere else blurred it → the row collapsed between mousedown and mouseup → the lower card shifted up under the cursor → the click never fired. Net effect: clicking a lower card's anchor did nothing while the rail jumped.Fix
Expansion keys on
:focus-visibleinstead of:focus-within(group-has-[:focus-visible]/card). Keyboard tabbing into a card still opens the reply bar — the accessibility reason focus-within existed — but a mouse click no longer pins it, so the collapse happens on hover-out while the pointer travels and layout is settled before the next click lands.One class change + comment. Verified: 25/25 ThreadCard tests, typecheck clean, compiled CSS contains the
:has(:focus-visible)rule.🤖 Generated with Claude Code
https://claude.ai/code/session_011iMXVvMG1u9VwWwYqLp4Gm