Reanimated builders support - #54
Conversation
9cb24a7 to
d9220ee
Compare
| if (this._deferNodeRemovalHandler) { | ||
| this._deferNodeRemovalHandler(() => { | ||
| this.emit('deferredDestroyComplete'); | ||
| }); |
There was a problem hiding this comment.
Main thing to look at here. I hate having to do this, but we need to delay removal of the lightning node and all child nodes so that the element can be animated out. Open to better suggestions here.
There was a problem hiding this comment.
No I think this makes sense. Can't animate the element if the element no longer exists.
| @@ -0,0 +1,3 @@ | |||
| ## @plextv/react-lightning-plugin-reanimated | |||
There was a problem hiding this comment.
| ## @plextv/react-lightning-plugin-reanimated | |
| ## react-lightning-plugin-reanimated |
?
You seem to have been removing it everywhere else, so should you do the same here? or have I misunderstood?
There was a problem hiding this comment.
I only removed it for storybook, just for display purposes
| } | ||
|
|
||
| break; | ||
| case 'scale': |
There was a problem hiding this comment.
should we also be handling scaleX and scaleY directly as well, like you do for translate?
m-hall
left a comment
There was a problem hiding this comment.
I haven't had a chance to test it, but I'm approving it to unblock you as I will be away
This adds support for animation builders in react-native. Eg:
See the storybook for examples. I haven't added every builder from reanimated (Bounce, Spin, etc). Just Slide and Fade for now.