Skip to content

fix: if statement breaks "env" - #154

Merged
cilindrox merged 1 commit into
plexinc:masterfrom
Xeroxxx:fix/env
Jul 28, 2025
Merged

fix: if statement breaks "env"#154
cilindrox merged 1 commit into
plexinc:masterfrom
Xeroxxx:fix/env

Conversation

@Xeroxxx

@Xeroxxx Xeroxxx commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

The statement introduced breaks the helmchart. If ingress or ADVERTISE_IP is not defined the chart fails as "env:" is missing.

@Xeroxxx
Xeroxxx requested a review from a team July 28, 2025 14:58
@Xeroxxx

Xeroxxx commented Jul 28, 2025

Copy link
Copy Markdown
Contributor Author

@cilindrox Please review.

@cilindrox cilindrox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @Xeroxxx !

@cilindrox cilindrox self-assigned this Jul 28, 2025
@cilindrox cilindrox added the bug label Jul 28, 2025
@cilindrox
cilindrox merged commit f7df1e4 into plexinc:master Jul 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants