fix: stop embedding upstream response bodies in upload errors#916
Closed
rareboe wants to merge 1 commit into
Closed
fix: stop embedding upstream response bodies in upload errors#916rareboe wants to merge 1 commit into
rareboe wants to merge 1 commit into
Conversation
When the game server's Cloud Run ingress rejects an oversized upload (32 MiB HTTP/1 request cap), the upstream 413 response is a Google front-end HTML error page. Embedding it in the thrown message leaked raw HTML into user-facing toasts and Slack reports. Log a truncated copy server-side for debugging and throw a clean status-based message instead.
Author
|
Wrong repo — agent8 no longer serves the backend; re-submitting against agent8-backend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api.upload-attachment.tsembedded the whole body into the thrown message →{ success: false, error: "Upload failed: 413 <html>..." }reached user toasts and SlackStorage upload rejected (<status>)message insteadTest plan
pnpm typecheck,eslinton the changed file passStorage upload rejected (413), no HTML🤖 Generated with Claude Code