Skip to content

Release/fix upload artifact #6790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ipdae wants to merge 4 commits into
base: release/280.0.0
Choose a base branch
from
Draft

Release/fix upload artifact #6790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad3b663
fix ArenaBoardPlayerCell ui layout
jonny-jeahyunchoi Feb 3, 2025
e5a2ba1
update version 280.0.1
jonny-jeahyunchoi Feb 3, 2025
2520f16
Run workflows in test branch
ipdae Feb 3, 2025
afadd72
Change toolbelt branch
ipdae Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
- preview
- release/*
- fast-track/*
- fix-upload-artifact
tags: [ "*" ]
pull_request:
types: [ ready_for_review, opened, reopened, auto_merge_enabled ]
Expand Down Expand Up @@ -185,7 +186,7 @@ jobs:
aws-region: ap-northeast-2

- name: release
uses: planetarium/9c-toolbelt@main
uses: planetarium/9c-toolbelt@feature/deprecate_runtime_api
with:
COMMAND_LIST: "release|player|${{ github.sha }}|${{ needs.extract.outputs.version }}|${{ needs.extract.outputs.network }}|${{ matrix.targetPlatform }}|${{ needs.extract.outputs.signing }}|--slack-channel=${{ secrets.SLACK_CHANNEL }}|--run-id=${{ github.run_id }}"
ENV: production
Expand Down
1 change: 1 addition & 0 deletions nekoyume/Assets/AddressableAssets/UI/Module/Arena/Board/ArenaBoardPlayerCell.prefab
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1809,6 +1809,7 @@ MonoBehaviour:
_ratingText: {fileID: 2468895205858989245}
_cpText: {fileID: 1991182203086928886}
_plusRatingText: {fileID: 4133636230288920637}
_minusRatingText: {fileID: 8538320612807046192}
_choiceButton: {fileID: 5759196546260136036}
guildMark: {fileID: 7038393542740975417}
guildMarkEmpty: {fileID: 2787409500368074896}
Expand Down
6 changes: 6 additions & 0 deletions nekoyume/Assets/_Scripts/UI/Module/Arena/Board/ArenaBoardPlayerCell.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ namespace Nekoyume.UI.Module.Arena.Board
using Cysharp.Threading.Tasks;
using Nekoyume.State;
using UniRx;
using Unity.Mathematics;

[Serializable]
public class ArenaBoardPlayerItemData
Expand Down Expand Up @@ -70,6 +71,8 @@ public class ArenaBoardPlayerCell

[SerializeField]
private TextMeshProUGUI _plusRatingText;
[SerializeField]
private TextMeshProUGUI _minusRatingText;

[SerializeField]
private ConditionalButton _choiceButton;
Expand Down Expand Up @@ -150,6 +153,9 @@ public override void UpdateContent(ArenaBoardPlayerItemData itemData)
_ratingText.text = _currentData.score.ToString("N0", CultureInfo.CurrentCulture);
_plusRatingText.gameObject.SetActive(_currentData.canFight);
_plusRatingText.text = _currentData.expectWinDeltaScore.ToString("N0", CultureInfo.CurrentCulture);
_minusRatingText.gameObject.SetActive(_currentData.canFight);

_minusRatingText.text = math.abs(_currentData.scoreOnLose).ToString("N0", CultureInfo.CurrentCulture);

_choiceButton.gameObject.SetActive(_currentData.canFight);
if (_currentData.canFight)
Expand Down
4 changes: 2 additions & 2 deletions nekoyume/ProjectSettings/ProjectSettings.asset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ PlayerSettings:
16:10: 0
16:9: 1
Others: 0
bundleVersion: 280.0.0
bundleVersion: 280.0.1
preloadedAssets: []
metroInputSource: 0
wsaTransparentSwapchain: 0
Expand Down Expand Up @@ -168,7 +168,7 @@ PlayerSettings:
iPhone: 0
tvOS: 0
overrideDefaultApplicationIdentifier: 1
AndroidBundleVersionCode: 284
AndroidBundleVersionCode: 285
AndroidMinSdkVersion: 24
AndroidTargetSdkVersion: 34
AndroidPreferredInstallLocation: 2
Expand Down