You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What changed: Added clj & clojure from clojure.org pre-builts for homebrew
Why: So that people can use clj & clojure via pkgx, pkgm, etc.
This PR has 2 commits:
build from source
vendor
I am not certain if either will work, or if vendoring is just easier for the team. I included both so that it would hopefully be easier to get this in one way or another.
To the best of my knowledge, using clj requires rlwrap but since pkgx does not currently have a rlwrap package the end-user must install it themselves (via brew or some other means).
@phrohdoh did your source build work? and did you evaluate rlwrap for packaging viability?
I do not know whether the source build worked, as I am unable to get my local pkgx working with my local pantry:
I am not certain if either will work [...]
I have not evaluated rlwrap for packaging viability, as it is not absolutely required. I believe thatclj is an rlwrap-based wrapper for clojure. So end-users can either use clojure without rlwrap installed or they can install rlwrap then use either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clj&clojurefrom clojure.org pre-builts for homebrewclj&clojureviapkgx,pkgm, etc.This PR has 2 commits:
I am not certain if either will work, or if vendoring is just easier for the team. I included both so that it would hopefully be easier to get this in one way or another.
Example release: https://github.com/clojure/brew-install/releases/tag/1.12.5.1654
AI Intent
Risk Assessment
Rollback Plan
Validation
devorbk.Internal/Public Boundary Check
added.