Skip to content

Format all html for source code boxes with indentation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dannyc5 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Format all html for source code boxes with indentation #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
090e178
Indent rendered source.
dannyc5 May 15, 2014
cad4436
Write specs. Remove line 1 xml tag from source code. Remove comments.
dannyc5 May 15, 2014
810e5f5
PENDING Known bugs in comments.
dannyc5 May 15, 2014
3110a10
Rspec passes. Formats in xhtml -- no html5 with nokogiri
dannyc5 May 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/style_guide/style/_partial.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

<input id="style-guide-toggle-<%= partial.id %>" type="checkbox" />
<label for="style-guide-toggle-<%= partial.id %>">
<pre class="style-guide-partial-source prettyprint linenums"><%= escape_for_display(partial.render) %></pre>
<pre class="style-guide-partial-source prettyprint linenums"><%= escape_for_display(partial.render_source_code) %></pre>
<div class="style-guide-toggle show">Show source code</div>
<div class="style-guide-toggle hide">Hide source code</div>
</label>
Expand Down
6 changes: 5 additions & 1 deletion lib/style_guide/partial.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ def identifiers
end

def render
@render ||= action_view.render(:file => path)
@render = action_view.render(file: path)
end

def render_source_code
@render = Nokogiri::HTML.fragment(render, 'utf-8').to_xhtml
end

private
Expand Down
10 changes: 10 additions & 0 deletions spec/lib/style_guide/partial_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,14 @@

it { should == "hi" }
end

describe "#render_source" do
let(:mock_view) { double(:view, :render => '<h1>Hello world</h1><div><h2>More stuff</h2><div><p>Mooooore stuff</p></div></div>') }

before { partial.stub(:action_view).and_return(mock_view) }

subject { partial.render_source_code }

it { should == "<h1>Hello world</h1><div>\n <h2>More stuff</h2>\n <div>\n <p>Mooooore stuff</p>\n </div>\n</div>" }
end
end