Support passing RTP extensions when writing samples.#3391
Support passing RTP extensions when writing samples.#3391
Conversation
f448d0a to
14cb039
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3391 +/- ##
==========================================
- Coverage 85.34% 85.20% -0.15%
==========================================
Files 81 81
Lines 9746 9751 +5
==========================================
- Hits 8318 8308 -10
- Misses 1006 1018 +12
- Partials 422 425 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c5fbb48 to
6b1ae1d
Compare
|
Improved test coverage and rebased to current master. Not sure about the API test failure, the new parameters to |
it's still a breaking change, please refer to Adding to a function does this #1841 solve your issue? |
6b1ae1d to
7466116
Compare
Right, I didn't think about this - introduced a new function.
Yes, copying most of the existing |
This is needed to set the
sdp.SDESMidURIandsdp.SDESRTPStreamIDURIRTP header extensions when sending samples to the different layers of simulcast tracks. At least I didn't find another way to do this.I considered reusing
rtp.Extensionbut that doesn't expose the internal data, so additional accessors and aNewExtension(id uint8, payload []byte) *Extensionfunction would have been required inrtp.