i18n(ja): fix straddling-bracket defects around bold UI labels - #23552
Merged
qiancai merged 8 commits intoAug 20, 2026
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
area/develop
|
Important Review skippedToo many files! This PR contains 235 files, which is 85 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (235)
You can disable this status message by setting the 📝 WalkthroughWalkthroughThis documentation-only change standardizes Japanese UI labels, quotation marks, and Markdown emphasis across AI, dashboard, connection, sample application, TiDB Cloud, monitoring, release-note, and troubleshooting guides. ChangesDocumentation formatting updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🟡 Moderate · up to The PR improves Japanese bold and quote formatting across many documentation pages, but the current text still contains incorrect support-control directions and an IAM-role instruction that may prevent readers from completing required setup, along with smaller label and grammar inconsistencies. Merge should wait for those corrections. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
12 tasks
qiancai
added
translation/no-need
yahonda
force-pushed
the
fix-straddling-bracket-defects-2026-08-18
branch
2 times, most recently
from
August 19, 2026 05:40
073f3d6 to
7b7b7ed
Compare
qiancai
approved these changes
Aug 19, 2026
[LGTM Timeline notifier]Timeline:
|
Corpus-wide sweep for a defect pattern flagged in earlier UI-label restoration work: a Japanese kagi-kakko quote pair (「」) split across the ** bold-span boundary instead of both landing consistently inside or outside, e.g. 「**Label」** or **Label**」 instead of the correct **Label** (or **「Label」** where EN's own doc genuinely quotes it). Each instance was verified against the release-8.5 (English) source before fixing: most resolve to stripping the stray quote marks entirely since EN plain-bolds the label with no decoration, a handful resolve to repositioning the quotes to match either EN's own quoting or the file's own established convention for that specific term. Also fixed a number of adjacent defects found while touching these lines: particles trapped inside a bold span's closing ** instead of sitting outside it, a few reconstructed garbled sentences where the bold span had swallowed unrelated content, and one case restoring a missing opening quote to match its closing counterpart.
…tor-alert-pagerduty.md Found via a user spot-check of the Subscriber Type line, which wasn't covered by the earlier pass in this PR: 購読者タイプの/「PagerDuty」を had a trapped particle plus a stray quote around PagerDuty. While in the file, also stripped the remaining non-straddling 「」 instances this PR hadn't reached yet (Project Settings, Alert Subscription, Add Subscriber, Test Connection, Save, Subscribe, Unsubscribe) — all confirmed plain in the EN source.
Independent 1:1 review of this PR against the EN source (release-8.5)
surfaced several places where quotes were repositioned instead of
stripped, or left inconsistently quoted next to an already-fixed
sibling on the same line:
- 14 dev-guide-sample-application-*.md / dev-guide-gui-vscode-sqltools.md:
"Connection Type" was repositioned to **「接続タイプ」** instead of
stripped; EN never quotes it, and one file's own sibling line already
had the plain form. Also stripped the adjacent Public/CA cert quotes
on the same lines (same defect, same fix).
- manage-user-access.md: Organization Settings/General/Time Zone/
Update were repositioned instead of stripped, contradicted by EN
(plain everywhere) and by this fix's own inconsistency with the
square-bracket-style "[組織設定] > [ユーザー]" occurrences elsewhere in
the same file. Normalized all occurrences to plain, unquoted bold.
- 5 files (connect-to-premium-via-alibaba-cloud-private-endpoint.md,
set-up-private-endpoint-connections-on-{alibaba-cloud,azure,
google-cloud}.md, set-up-private-endpoint-connections-serverless.md):
the wrong span was bolded as the UI label (接続方法, "connection
method") when EN's actual label at that position is **Connect With**,
with "connection method" as plain descriptive text. Fixed to bold
the correct label. Also stripped sibling quote decoration around
Connection Type/Private Endpoint/Active/Settings/Networking found
on the same lines while fixing this.
- size-your-cluster.md, configure-external-storage-access.md: a couple
more same-line siblings (Submit, Data/Export) left quoted next to an
already-stripped instance, now consistent.
Per the standing policy of removing all Japanese quote decoration that
EN doesn't have, even where a file's own convention had kept it.
yahonda
force-pushed
the
fix-straddling-bracket-defects-2026-08-18
branch
from
August 19, 2026 06:27
7b7b7ed to
aa17ed7
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 65
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: de611202-4707-4558-b33c-2623219c6368
📒 Files selected for processing (77)
ai/examples/image-search-with-pytidb.mdai/integrations/tidb-mcp-claude-desktop.mdai/integrations/tidb-mcp-vscode.mdbest-practices/grafana-monitor-best-practices.mdbest-practices/saas-best-practices.mddashboard/dashboard-diagnostics-access.mddashboard/dashboard-faq.mddashboard/dashboard-key-visualizer.mddashboard/dashboard-log-search.mddashboard/dashboard-overview.mddashboard/dashboard-slow-query.mddashboard/dashboard-statement-details.mddevelop/dev-guide-aws-appflow-integration.mddevelop/dev-guide-gui-datagrip.mddevelop/dev-guide-gui-dbeaver.mddevelop/dev-guide-gui-mysql-workbench.mddevelop/dev-guide-gui-navicat.mddevelop/dev-guide-gui-vscode-sqltools.mddevelop/dev-guide-sample-application-golang-gorm.mddevelop/dev-guide-sample-application-golang-sql-driver.mddevelop/dev-guide-sample-application-java-hibernate.mddevelop/dev-guide-sample-application-java-jdbc.mddevelop/dev-guide-sample-application-java-mybatis.mddevelop/dev-guide-sample-application-java-spring-boot.mddevelop/dev-guide-sample-application-nodejs-mysql2.mddevelop/dev-guide-sample-application-nodejs-mysqljs.mddevelop/dev-guide-sample-application-nodejs-prisma.mddevelop/dev-guide-sample-application-nodejs-sequelize.mddevelop/dev-guide-sample-application-nodejs-typeorm.mddevelop/dev-guide-sample-application-python-django.mddevelop/dev-guide-sample-application-python-mysql-connector.mddevelop/dev-guide-sample-application-python-mysqlclient.mddevelop/dev-guide-sample-application-python-peewee.mddevelop/dev-guide-sample-application-python-pymysql.mddevelop/dev-guide-sample-application-python-sqlalchemy.mddevelop/dev-guide-sample-application-ruby-mysql2.mddevelop/dev-guide-sample-application-ruby-rails.mddm/dm-webui-guide.mdexternal-storage-uri.mdtidb-cloud/backup-and-restore.mdtidb-cloud/changefeed-sink-to-apache-pulsar.mdtidb-cloud/changefeed-sink-to-cloud-storage.mdtidb-cloud/configure-external-storage-access.mdtidb-cloud/configure-security-settings.mdtidb-cloud/configure-sql-users.mdtidb-cloud/data-service-get-started.mdtidb-cloud/data-service-manage-endpoint.mdtidb-cloud/essential-database-audit-logging.mdtidb-cloud/explore-data-with-chat2query.mdtidb-cloud/features.mdtidb-cloud/integrate-tidbcloud-with-airbyte.mdtidb-cloud/integrate-tidbcloud-with-n8n.mdtidb-cloud/manage-user-access.mdtidb-cloud/migrate-from-mysql-using-aws-dms.mdtidb-cloud/migrate-from-mysql-using-data-migration.mdtidb-cloud/monitor-alert-email.mdtidb-cloud/monitor-alert-flashduty.mdtidb-cloud/monitor-alert-pagerduty.mdtidb-cloud/monitor-alert-slack.mdtidb-cloud/monitor-alert-zoom.mdtidb-cloud/naming-conventions-for-data-import.mdtidb-cloud/pause-or-resume-tidb-cluster.mdtidb-cloud/premium/backup-and-restore-premium.mdtidb-cloud/premium/connect-to-premium-via-alibaba-cloud-private-endpoint.mdtidb-cloud/premium/create-tidb-instance-premium.mdtidb-cloud/premium/dual-layer-data-encryption-premium.mdtidb-cloud/premium/premium-export.mdtidb-cloud/releases/release-notes-2022.mdtidb-cloud/releases/release-notes-2023.mdtidb-cloud/scale-tidb-cluster.mdtidb-cloud/set-up-private-endpoint-connections-on-google-cloud.mdtidb-cloud/size-your-cluster.mdtidb-cloud/tidb-cloud-billing.mdtidb-cloud/tidb-cloud-import-local-files.mdtidb-cloud/tidb-cloud-log-redaction.mdtidb-cloud/tidb-cloud-tls-connect-to-dedicated.mdtidb-troubleshooting-map.md
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.
Found by CodeRabbit review on a sibling PR: the quoted request title 「 TiDB Cloud Essential...」 had a stray leading space after the opening quote mark, not present in the English source.
- best-practices/grafana-monitor-best-practices.md, dashboard/dashboard-overview.md: unify メトリック -> メトリクス (Metrics) to match the other reference to the same UI element in each file - develop/dev-guide-gui-navicat.md: move の outside the bold span and fix an awkward field-selection phrasing - tidb-cloud/essential-database-audit-logging.md: add the missing "in the lower-right corner" location for the ? icon - tidb-cloud/manage-user-access.md: restore Update (2 occurrences)
The English source never wraps a bold UI-label span (e.g. Click **Connect**) in quotes, but the ja translation had accumulated 「」 around many such spans (e.g. **「接続」**), across single-word button labels, symbols (**「+」**, **「...」**), and longer descriptive labels (**「クラウドストレージからデータをインポート」**). Verified this pattern holds against EN for a representative sample across short and long labels before doing a mechanical, corpus-wide strip: **「X」** -> **X**, applied only where the quote marks sit immediately inside the bold delimiters (1,577 occurrences across 233 files). This supersedes the narrower carve-outs used in PR pingcap#23551/pingcap#23552, which kept a handful of terms quoted for in-file convention (接続 タイプ, スキーマロード, 接続方法, 組織設定, etc.) - per the standing policy, in-file consistency is not a reason to keep quoting a term EN never quotes. Verified per-file: line count, ** count, [ count, and ] count are all unchanged (0 anomalies across all 233 changed files) - only the 「」 characters were removed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
6 tasks
…defects-2026-08-18 Resolved 54 file conflicts: took this branch's straddling-bracket fixes as the base, then re-applied the quote-stripping substitution (**「X」**->**X**) on top, so both fixes combine cleanly. Verified 0 remaining quote-wrapped bold spans and 0 bracket-count anomalies across all 54 files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
test seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
ti-chi-bot
Bot
added
size/XXL
Follow-up to the fix-strip-non-en-quotes-2026-08-20 merge - this instance was in a non-conflicted region so the merge's conflict-only reprocessing pass missed it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Corpus-wide sweep for the "straddling bracket" defect class in the Japanese (ja) translation: a Japanese kagi-kakko quote pair (
「」) split across the**bold-span boundary instead of both landing consistently on the same side, e.g.:Each instance was verified against the English source (
release-8.5branch) before fixing:**Connection Type**,**Save**, etc.).Also fixed along the way:
**instead of sitting outside it.Verification: corpus-wide re-scan for the straddling-bracket pattern found 0 remaining matches; bracket/
**-parity check across the full diff found 0 issues across 90 files.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit