Skip to content

i18n(ja): restore genuine 2-word TiDB Cloud UI labels to English - #23543

Closed
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ui-labels-english-2-word-unconfirmed-2026-08-17
Closed

i18n(ja): restore genuine 2-word TiDB Cloud UI labels to English#23543
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ui-labels-english-2-word-unconfirmed-2026-08-17

Conversation

@yahonda

@yahonda yahonda commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

These 228 candidate labels were skipped by the mechanical 2-word batch (#23535) because they couldn't be confirmed via a plain dbaas-ui grep — mostly third-party console fields (AWS, Azure, Alibaba Cloud, GCP, Kafka, Datadog, New Relic, n8n, Airbyte, PagerDuty, Slack) that dbaas-ui doesn't cover, plus a handful of TiDB-native labels the grep missed.

Each candidate was individually triaged against EN (release-8.5) and, for TiDB-native items, dbaas-ui with a strict STRONG/WEAK/COMMENT_ONLY/NO_HIT classifier, distinguishing genuine clickable UI elements from prose/marketing/category-header bullets that merely share the same words (the "No cost"/"High availability" false-positive pattern from earlier batches).

265 occurrences fixed across 47 files. ~70 further candidates were deliberately left in Japanese as category-header/concept-heading prose, not clickable UI (same precedent as architecture-concepts.md).

Along the way this also fixed several pre-existing defects surfaced by the same EN comparison:

  • Mismatched AWS IAM button-label pairs (Attach Policies vs Attach Policy previously translated as the same word)
  • Particle- and bracket-trapped-in-bold spans (including the [仮想**ネットワーク]** defect flagged earlier this session)
  • Word-order/position-pairing mis-mappings (Source/Target engine, Signing method/Account key, Export Path)
  • A mistranslation (一般公開→Public accessible)
  • An orphaned bracket left over from an incomplete straddling-bracket fix

Import dashboard (monitor-new-relic-integration.md) was explicitly skipped — already handled by #23540.

⚠️ Known conflicts with other open PRs

This PR's base is the same tip as #23535, and the two independently touch many of the same files (~40 overlapping lines). I already worked out and verified the correct merged resolution for all 40 conflicting hunks (combining whichever side had already progressed a given label to English, plus a few extra fixes found while reconciling: a dropped particle in VPC Peeringを, an incorrect Signing method/Account key field-value swap, and a garbled Availability zone label). That resolution is not included in this PR's diff (to keep this PR's diff scoped to only its own new content), but is ready to hand to whoever merges these two PRs — ping me and I'll apply it directly.

While working out that resolution, I also discovered (but have not fixed, as it's out of this PR's scope) that #23535 independently conflicts with #23519 (3/4-word batch, ~142 conflict markers) and with #23516 (Note-label normalization, ~3 conflict markers). Both are pre-existing conflicts between those two already-open PRs, unrelated to this PR's changes — flagging for whoever sequences the merge order.

Test plan

@ti-chi-bot

ti-chi-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2026
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • ^master$
  • ^release-8.5$
  • ^ja/update-pr-template$

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b9e0d371-95ae-4d3c-925f-814b0d236929

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2026
yahonda added a commit to yahonda/docs that referenced this pull request Aug 17, 2026
EN uses "New principals" (lowercase p) in backup-and-restore.md's
GCS bucket-access step, unlike the "New Principals" (capital P)
field-label wording used in the other 3 files this batch touched.
Found during review of pingcap#23543.
@yahonda
yahonda marked this pull request as ready for review August 17, 2026 06:19
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 17, 2026
@yahonda
yahonda force-pushed the fix-ui-labels-english-2-word-unconfirmed-2026-08-17 branch from 1a25ced to 6ab8bf9 Compare August 18, 2026 01:07
yahonda added a commit to yahonda/docs that referenced this pull request Aug 18, 2026
…l refresh | Overwrite

EN shows these as literal Airbyte UI dropdown values: "Set Destination
Namespace to Custom format and set Namespace Custom Format to test"
and "Choose the Sync mode to Full refresh | Overwrite." All three
values (Custom format, Namespace Custom Format, test, Full refresh |
Overwrite) were left in Japanese even after Destination Namespace and
Sync mode's own field-name labels were fixed to English elsewhere.

Also rephrased "Sync mode を Full refresh | Overwrite に選択" (unnatural
を...に選択 construction) to "Sync mode で Full refresh | Overwrite を選択"
per user feedback.

Found while reviewing pingcap#23543.
…onfirmed batch)

These 228 candidate labels were skipped by the mechanical 2-word batch
(pingcap#23535) because they couldn't be confirmed via a plain dbaas-ui grep
(mostly third-party console fields — AWS, Azure, Alibaba Cloud, GCP,
Kafka, Datadog, New Relic, n8n, Airbyte, PagerDuty, Slack — which
dbaas-ui doesn't cover, plus a handful of TiDB-native labels the
grep missed). Each was individually triaged against EN (release-8.5)
and, for TiDB-native items, dbaas-ui with a strict STRONG/WEAK/
COMMENT_ONLY/NO_HIT classifier, distinguishing genuine clickable UI
elements from prose/marketing/category-header bullets that merely
share the same words (the "No cost"/"High availability" false-positive
pattern from earlier batches).

265 occurrences fixed across 47 files. ~70 further candidates were
deliberately left in Japanese as category-header/concept-heading
prose, not clickable UI (same precedent as architecture-concepts.md).

Along the way this also fixed several pre-existing defects surfaced
by the same EN comparison: mismatched AWS IAM button-label pairs
(Attach Policies vs Attach Policy treated as the same word), particle-
and bracket-trapped-in-bold spans, a word-order/position-pairing
mis-mapping (Source/Target engine, Signing method/Account key,
Export Path), a mistranslation (一般公開→Public accessible), and an
orphaned bracket left over from an incomplete straddling-bracket fix.

"Import dashboard" (monitor-new-relic-integration.md) was explicitly
skipped — already handled by pingcap#23540.
@yahonda
yahonda force-pushed the fix-ui-labels-english-2-word-unconfirmed-2026-08-17 branch from 6ab8bf9 to 2c38f07 Compare August 19, 2026 01:27
yahonda added a commit to yahonda/docs that referenced this pull request Aug 19, 2026
…l refresh | Overwrite

EN shows these as literal Airbyte UI dropdown values: "Set Destination
Namespace to Custom format and set Namespace Custom Format to test"
and "Choose the Sync mode to Full refresh | Overwrite." All three
values (Custom format, Namespace Custom Format, test, Full refresh |
Overwrite) were left in Japanese even after Destination Namespace and
Sync mode's own field-name labels were fixed to English elsewhere.

Also rephrased "Sync mode を Full refresh | Overwrite に選択" (unnatural
を...に選択 construction) to "Sync mode で Full refresh | Overwrite を選択"
per user feedback.

Found while reviewing pingcap#23543.
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 19, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-19 02:38:34.47531203 +0000 UTC m=+37349.646406133: ☑️ agreed by qiancai.

@qiancai

qiancai commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

@yahonda, before I merge this pull request, would you please confirm whether the changes in this pull request are ready for merge? If so, please remove "unconfirmed patch" from the pull request title.

@yahonda yahonda changed the title i18n(ja): restore genuine 2-word TiDB Cloud UI labels to English (unconfirmed batch) i18n(ja): restore genuine 2-word TiDB Cloud UI labels to English Aug 19, 2026
@yahonda

yahonda commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review. I have updated the subject. Let me resolve the conflict then.

…ui-labels-english-2-word-unconfirmed-2026-08-17

# Conflicts:
#	tidb-cloud/integrate-tidbcloud-with-airbyte.md
@ti-chi-bot

ti-chi-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 19, 2026
@yahonda

yahonda commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

Closed since #23545 has been merged.

@yahonda yahonda closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants