Skip to content

i18n(ja): restore English CSV Configuration field names - #23538

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-csv-config-labels-2026-08-17
Open

i18n(ja): restore English CSV Configuration field names#23538
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-csv-config-labels-2026-08-17

Conversation

@yahonda

@yahonda yahonda commented Aug 17, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

csv-config-for-import-data.md documents the literal field names shown in TiDB Cloud's CSV Configuration window (Separator, Delimiter, Null Value, Backslash Escape, Skip Header) — all confirmed as genuine UI labels via tidbcloud/dbaas-ui (dbaas/screens/DataImportV2/CSVConfiguration.tsx, each rendered as its own <Typography variant="label-lg"> field label). These were translated into Japanese instead of kept in English, both in the section headings and their inline body references.

Also fixed the same "Edit CSV configuration" button + field-name list in tidb-cloud-import-local-files.md and migrate-sql-shards.md, and a column-header fluency issue in the Backslash Escape sequence table (変換された → 変換後).

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hfxsd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yahonda, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5a86aef9-e2c9-4f13-9bd9-202f818d1934

📥 Commits

Reviewing files that changed from the base of the PR and between a344db9 and 10f58e5.

📒 Files selected for processing (3)
  • tidb-cloud/csv-config-for-import-data.md
  • tidb-cloud/migrate-sql-shards.md
  • tidb-cloud/tidb-cloud-import-local-files.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 17, 2026
@yahonda
yahonda marked this pull request as ready for review August 17, 2026 04:35
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 17, 2026
@qiancai

qiancai commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

@yahonda, there are two conflicts in this PR. Would you check and resolve them? Thanks.

csv-config-for-import-data.md documents the literal field names shown
in TiDB Cloud's CSV Configuration window (Separator, Delimiter, Null
Value, Backslash Escape, Skip Header) — all confirmed as genuine UI
labels via the tidbcloud/dbaas-ui source
(dbaas/screens/DataImportV2/CSVConfiguration.tsx, each rendered as
its own <Typography variant="label-lg"> field label). These were
translated into Japanese instead of kept in English, both in the
section headings and their inline body references.

Also fixed the same 'Edit CSV configuration' button + field-name list
in tidb-cloud-import-local-files.md and migrate-sql-shards.md, and a
column-header fluency issue in the Backslash Escape sequence table
(変換された -> 変換後).
@yahonda
yahonda force-pushed the fix-csv-config-labels-2026-08-17 branch from 6da2455 to 10f58e5 Compare August 19, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants