cloud: document Premium manual import mapping - #23504
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe documentation defines source-file mapping rules, plan-specific limitations, and Premium import workflows for Amazon S3 and Alibaba OSS. It covers folder URIs, automatic and manual mappings, pre-checks, completion verification, and troubleshooting. ChangesData import mapping documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@xuanyu66 PTAL |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3e65ba8f-8d09-485c-9c82-07a997dc8dbe
📒 Files selected for processing (3)
tidb-cloud/naming-conventions-for-data-import.mdtidb-cloud/premium/import-csv-files-premium.mdtidb-cloud/premium/import-from-s3-premium.md
|
@coderabbitai full review |
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3c86eb4a-6cee-459c-ab84-7ec6c5b5fa2c
📒 Files selected for processing (3)
tidb-cloud/naming-conventions-for-data-import.mdtidb-cloud/premium/import-csv-files-premium.mdtidb-cloud/premium/import-from-s3-premium.md
|
@coderabbitai full review |
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 37fd6fdb-01f1-4b7e-880f-adbff914e034
📒 Files selected for processing (3)
tidb-cloud/naming-conventions-for-data-import.mdtidb-cloud/premium/import-csv-files-premium.mdtidb-cloud/premium/import-from-s3-premium.md
|
@coderabbitai full review |
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 80ba5d4d-89f5-45fd-8afb-8878355db144
📒 Files selected for processing (3)
tidb-cloud/naming-conventions-for-data-import.mdtidb-cloud/premium/import-csv-files-premium.mdtidb-cloud/premium/import-from-s3-premium.md
|
|
||
| </CustomContent> | ||
|
|
||
| In the mapping step of the import wizard, deselect **Use TiDB file naming conventions for automatic mapping**, and then fill in the **Source**, **Target Database**, and **Target Table** fields. The **Source** field accepts a file name pattern relative to the source URI and supports the `*` and `?` wildcards. |
There was a problem hiding this comment.
The ? wildcard is not supported on the Premium import path. Premium import runs on IMPORT INTO, whose file matching only supports the * and [] wildcards — see the official IMPORT INTO documentation:
In the
fileLocationparameter, you can specify a single file, or use the*and[]wildcards to match multiple files for import.
On this path, a ? in the pattern is silently treated as a literal character, so a pattern like my-data?.csv matches no files and only surfaces as an "empty data set" warning at pre-check time. (? does work in the legacy Dedicated custom mapping, where the backend translates it into a regex ., but that does not apply to Premium.)
Suggest changing this to "supports the * and [] wildcards" (or scoping the wording per plan). The same claim also appears in tidb-cloud/premium/import-csv-files-premium.md (both storage provider tabs) and tidb-cloud/premium/import-from-s3-premium.md.
There was a problem hiding this comment.
Thanks, confirmed. I updated the affected pages so the wildcard wording follows the visible mapping workflow:
| Scope | File-pattern behavior | Customer-issued SQL IMPORT INTO |
|---|---|---|
| TiDB Self-Managed v8.5 | * and []; ? is literal |
Supported |
| Starter with Destination Mapping | *, ?, and [] |
Supported |
| Essential and Premium with Source Files Mapping | * and []; ? is literal |
Supported |
| Dedicated with Destination Mapping | *, ?, and [] |
Documented for Amazon S3 and GCS |
The Starter and Essential SQL availability entries were also verified, so the TiDB X limitations table is corrected in this PR. The public wording uses service plans and visible workflow labels without exposing architecture generations.
What is changed, added or deleted? (Required)
This PR aligns the TiDB Cloud import documentation with the current console and file-matching behavior:
*,?, and[]for Destination Mapping, and*and[]for Source Files Mapping andIMPORT INTO.IMPORT INTOreferences with the wildcard syntax for the workflow they document.IMPORT INTOsupport on Starter and Essential.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
IMPORT INTOsupport on TiDB Cloud ServerlessIMPORT INTOwildcard path matchingValidation
./scripts/markdownlinton all nine changed documentation filespython3 scripts/file-format-lint.pyon all nine changed documentation filespython3 scripts/check-manual-line-breaks.pyon all nine changed documentation filesgit diff --checkIMPORT INTO.AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit