Skip to content

Added send via notification feature#3359

Merged
Corepex merged 4 commits into2025.4from
3132-notifications-share-via-notification-missing
Apr 22, 2026
Merged

Added send via notification feature#3359
Corepex merged 4 commits into2025.4from
3132-notifications-share-via-notification-missing

Conversation

@Corepex
Copy link
Copy Markdown
Contributor

@Corepex Corepex commented Apr 20, 2026

Changes in this pull request

Resolves #3132

Additional info

This pull request introduces a new "Share via Notifications" feature to the asset, data object, and document editor toolbars. It adds a context menu item that allows users with the appropriate permission to share the currently opened item via a notification, and opens a modal for composing the notification with the item pre-attached. The implementation is modular and reuses a new custom hook for consistency across editors.

Key changes:

Feature Addition: Share via Notifications

  • Added a new context menu item, "Share via Notifications", to the asset, data object, and document editor toolbars. This option is only visible to users with the SendNotifications permission and when an item is available to share. Selecting it opens a modal to send a notification with the item attached. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

Reusable Hook Implementation

  • Introduced useShareViaNotification hook to encapsulate logic for the context menu item and modal, ensuring DRY code and consistent behavior across modules.

Notification Modal Enhancement

  • Updated SendNotificationModal to accept an initial attachment and pre-fill the attachment field when opened, improving user experience.

Localization

  • Added a translation entry for "Share via Notifications" to support internationalization.

@Corepex Corepex self-assigned this Apr 20, 2026
@Corepex Corepex requested a review from xIrusux April 20, 2026 09:38
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@xIrusux xIrusux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Corepex Corepex linked an issue Apr 21, 2026 that may be closed by this pull request
@Corepex Corepex merged commit 2b5b8d5 into 2025.4 Apr 22, 2026
1 check passed
@Corepex Corepex deleted the 3132-notifications-share-via-notification-missing branch April 22, 2026 07:28
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Notifications] Share via notification missing

2 participants