Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Changes in this pull request
Resolves #3132
Additional info
This pull request introduces a new "Share via Notifications" feature to the asset, data object, and document editor toolbars. It adds a context menu item that allows users with the appropriate permission to share the currently opened item via a notification, and opens a modal for composing the notification with the item pre-attached. The implementation is modular and reuses a new custom hook for consistency across editors.
Key changes:
Feature Addition: Share via Notifications
SendNotificationspermission and when an item is available to share. Selecting it opens a modal to send a notification with the item attached. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Reusable Hook Implementation
useShareViaNotificationhook to encapsulate logic for the context menu item and modal, ensuring DRY code and consistent behavior across modules.Notification Modal Enhancement
SendNotificationModalto accept an initial attachment and pre-fill the attachment field when opened, improving user experience.Localization