Open
Conversation
|
xIrusux
approved these changes
Apr 20, 2026
Contributor
xIrusux
left a comment
xIrusux
left a comment
There was a problem hiding this comment.
LGTM but lets take care of the sonar qube issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #3352
Blocked by: pimcore/studio-backend-bundle#1760
Additional info
This pull request enhances the
QuantityValueContainerby adding a search functionality to filter quantity value units. It introduces a search input in the toolbar, updates the API query to support filtering, and includes the corresponding translation key.Feature: Search Functionality for Quantity Value Units
SearchInputcomponent to the toolbar, allowing users to filter quantity value units by a search term. The search resets pagination to the first page and displays a loading state while fetching results. (assets/js/src/core/modules/quantity-value/quantity-value-container.tsx) [1] [2] [3]useUnitQuantityValueUnitsCollectionQuery) to include acolumnFiltersparameter when a search filter is present, enabling backend filtering of results. (assets/js/src/core/modules/quantity-value/quantity-value-container.tsx)UI/UX Improvements
Toolbarfrom'mini'to'extra-small'for better spacing. (assets/js/src/core/modules/quantity-value/quantity-value-container.tsx)Localization
quantity-values.searchfor the search input placeholder. (translations/studio.en.yaml)