Skip to content

Added onFinish callback to config create#3328

Merged
Corepex merged 2 commits into2025.4from
2973-widget-editor-open-new-widget-after-creation
Apr 20, 2026
Merged

Added onFinish callback to config create#3328
Corepex merged 2 commits into2025.4from
2973-widget-editor-open-new-widget-after-creation

Conversation

@Corepex
Copy link
Copy Markdown
Contributor

@Corepex Corepex commented Apr 10, 2026

Changes in this pull request

Resolves #2973

Additional info

This pull request updates the widget creation flow to ensure that the newly created widget's unique id is used throughout the process, rather than its name. This improves consistency and allows for more reliable widget handling after creation. The most important changes are:

Widget Creation Callback Interface:

  • Changed the signature of the createWidget function and its callback so that it now passes the widget's id (a string) instead of its name to the onFinish callback. This affects both the type definition and the implementation. [1] [2]

Widget Creation Implementation:

  • Updated the createWidget function to extract the id from the API response after widget creation and pass it to the onFinish callback, instead of the widget's name.

Widget Editor Provider Logic:

  • Updated WidgetEditorProvider to use the new id parameter in the callback, and to call openWidget(id, widgetType) after a widget is created, ensuring the correct widget is opened.

These changes make the widget creation flow more robust by consistently using the widget's unique identifier.

@Corepex Corepex self-assigned this Apr 10, 2026
@Corepex Corepex linked an issue Apr 10, 2026 that may be closed by this pull request
@Corepex Corepex requested a review from xIrusux April 10, 2026 07:55
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 10, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Copy Markdown
Contributor

@xIrusux xIrusux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pls accept sonar qube issues

@Corepex Corepex merged commit 6999258 into 2025.4 Apr 20, 2026
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2026
@Corepex Corepex deleted the 2973-widget-editor-open-new-widget-after-creation branch April 20, 2026 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Widget Editor] Open new widget after creation

2 participants