-
Notifications
You must be signed in to change notification settings - Fork 13
Perps #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perps #489
Changes from 133 commits
44810c4
da50f61
95711dc
d423411
c5d3946
c5764c1
2cf5fb2
4161560
3fb9187
d44fecc
cbf3078
17135f5
7dc3140
e48486c
33e6d69
3e4c0f1
467fa54
e5dcece
8909306
2aa6950
643919b
8a9ea7e
ec4a325
0b66c9c
68cbc2b
96eb832
ad8ac0f
3469b56
9eca26f
c203d0e
100769e
7073c51
8e7ca5c
7f93b3a
63ed3f3
039f677
5ad6251
d50d38d
1f7b025
a6015c1
9237fb4
15a2774
6f3fb95
6a2f78c
416ed68
8029b36
9c227ad
c6b97bd
6ba304e
8c30b40
50de434
ac4a4de
7de7959
69d3b76
c0f429a
7d9e08d
b9e475b
60e9c31
adafe01
aabc2bd
0d29cff
22abdfe
3629aec
62c9b65
a40aea7
20817fb
055a6fb
35d5bbc
bcc6853
8c5c554
d7f0a94
a6fbe25
b16a1e8
3993187
26d997c
33b0586
d1414ff
ceeec85
aa01e7e
311e952
3f48bb5
c8ae0d8
bd68cda
f11602d
78fc7b5
d20140b
02a37d8
9c7de98
966b9f9
53b77ed
f2712f1
50c3644
a4af822
4e587a6
c9edd49
cda6d02
174de53
d31fd30
419ba7a
9991f40
4cd75c0
534c3b6
c485a25
1a28c3b
480c09c
e98e1d0
71f3f56
37628f7
3a9cc79
43b03d0
d839710
e81df97
ef605f2
0432f17
b94b29c
90f8c4e
23834ea
e47f8f3
d866e19
0fc70a2
db30a2e
5a6a330
8adcbda
f11477a
97056f2
e2a7abd
425b628
7d338b7
d5938d6
9ab23a9
e448eea
ae0f838
1e63d6b
29afd3b
adef24d
128f99a
578c895
ce7d078
cf90f30
56c8e4d
48807cb
da3164d
178abb0
1f13cb9
69ff7bc
7506c20
1ab9b85
1b4d117
2d050fd
48d4d1e
0ceec49
04acd02
ebf4981
eca3b16
f6ccf89
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| "scripts": { | ||
| "dev": "vite", | ||
| "dev:functions": "wrangler pages dev build --port 5173 --live-reload", | ||
| "build": "VITE_COMMIT_SHA=$CF_PAGES_COMMIT_SHA VITE_VERSION=$npm_package_version vite build", | ||
| "build": "NODE_OPTIONS='--max-old-space-size=8192' VITE_COMMIT_SHA=$CF_PAGES_COMMIT_SHA VITE_VERSION=$npm_package_version vite build", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Look for CommonJS patterns in config files after switching to ESM
rg -n "module\.exports|require\(" -g "*config*.{js,ts,cjs,mjs}" -g ".eslintrc.*" .Repository: pillarwallet/x Length of output: 1034 🏁 Script executed: #!/bin/bash
# Find all config files in the repository
fd -e "js" -e "ts" -e "cjs" -e "mjs" | rg "^[^/]*\.(config\.)?(js|ts|cjs|mjs)$|^\..*rc.*$" | head -30Repository: pillarwallet/x Length of output: 150 🏁 Script executed: #!/bin/bash
# Check the package.json to confirm the "type": "module" setting
cat package.json | head -20Repository: pillarwallet/x Length of output: 935 Migrate CommonJS config files to ESM or rename to Multiple config files use CommonJS syntax that will break with ESM:
🤖 Prompt for AI Agents |
||
| "preview": "vite preview", | ||
| "test": "vitest", | ||
| "test:watch": "eslint . && vitest", | ||
|
|
@@ -24,11 +24,13 @@ | |
| "@etherspot/intent-sdk": "1.0.0-alpha.12", | ||
| "@etherspot/modular-sdk": "6.1.1", | ||
| "@etherspot/transaction-kit": "2.1.4", | ||
| "@hookform/resolvers": "^5.2.2", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: npm view `@hookform/resolvers`@^5.2.2 version 2>/dev/null || npm view `@hookform/resolvers` version
npm view `@nktkas/hyperliquid`@^0.30.2 version 2>/dev/null || npm view `@nktkas/hyperliquid` versionRepository: pillarwallet/x Length of output: 70 🏁 Script executed: cd /tmp && cat << 'EOF' > check_versions.js
const https = require('https');
function getPackageVersion(pkgName, specVersion) {
return new Promise((resolve) => {
https.get(`https://registry.npmjs.org/${pkgName}`, (res) => {
let data = '';
res.on('data', chunk => data += chunk);
res.on('end', () => {
try {
const pkg = JSON.parse(data);
const latest = pkg['dist-tags'].latest;
resolve({ package: pkgName, specVersion, latest });
} catch (e) {
resolve({ package: pkgName, specVersion, error: 'Failed to parse' });
}
});
}).on('error', err => resolve({ package: pkgName, specVersion, error: err.message }));
});
}
Promise.all([
getPackageVersion('@hookform/resolvers', '^5.2.2'),
getPackageVersion('@nktkas/hyperliquid', '^0.30.2')
]).then(results => {
results.forEach(r => console.log(JSON.stringify(r)));
});
EOF
node check_versions.jsRepository: pillarwallet/x Length of output: 207 🏁 Script executed: # Search for usage of these packages in the codebase
echo "=== Searching for `@hookform/resolvers` usage ==="
rg "@hookform/resolvers" --type ts --type tsx --type js --type jsx
echo -e "\n=== Searching for `@nktkas/hyperliquid` usage ==="
rg "@nktkas/hyperliquid" --type ts --type tsx --type js --type jsx
echo -e "\n=== Checking package.json context ==="
cat package.json | grep -A 2 -B 2 "@hookform/resolvers"
cat package.json | grep -A 2 -B 2 "@nktkas/hyperliquid"Repository: pillarwallet/x Length of output: 630 @hookform/resolvers and Both dependencies are at the latest available versions ( 🤖 Prompt for AI Agents |
||
| "@hypelab/sdk-react": "1.0.4", | ||
| "@lifi/sdk": "3.6.8", | ||
| "@mui/icons-material": "5.16.6", | ||
| "@mui/joy": "5.0.0-beta.48", | ||
| "@mui/material": "5.16.6", | ||
| "@nktkas/hyperliquid": "^0.30.2", | ||
| "@privy-io/react-auth": "2.16.0", | ||
| "@radix-ui/react-accordion": "^1.2.11", | ||
| "@radix-ui/react-alert-dialog": "^1.1.14", | ||
|
|
@@ -89,11 +91,13 @@ | |
| "iconsax-react": "0.0.8", | ||
| "identicon.js": "2.3.3", | ||
| "input-otp": "^1.4.2", | ||
| "lightweight-charts": "^5.1.0", | ||
| "lodash": "4.17.21", | ||
| "lucide-react": "^0.462.0", | ||
| "luxon": "3.5.0", | ||
| "mime": "4.0.4", | ||
| "moment": "2.30.1", | ||
| "next-themes": "^0.4.6", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check how next-themes is used in the codebase
echo "=== Searching for next-themes usage ==="
rg -n "next-themes" --type ts --type tsx -C 3 2>/dev/null || rg -n "next-themes" -g "*.ts" -g "*.tsx" -C 3
echo ""
echo "=== Checking ThemeProvider setup ==="
rg -n "ThemeProvider" -g "*.tsx" -g "*.ts" -C 5Repository: pillarwallet/x Length of output: 32303 🏁 Script executed: cat -n src/apps/perps/components/ui/sonner.tsxRepository: pillarwallet/x Length of output: 1161 🏁 Script executed: # Search for next-themes ThemeProvider setup
rg "ThemeProvider.*next-themes" -g "*.ts" -g "*.tsx"
rg "from.*next-themes" -g "*.ts" -g "*.tsx"Repository: pillarwallet/x Length of output: 137 Remove unused
🤖 Prompt for AI Agents |
||
| "patch-package": "8.0.0", | ||
| "plausible-tracker": "0.3.9", | ||
| "prop-types": "15.8.1", | ||
|
|
@@ -128,7 +132,8 @@ | |
| "viem": "2.37.1", | ||
| "vite-plugin-svgr": "4.3.0", | ||
| "wagmi": "2.14.16", | ||
| "webfontloader": "1.6.28" | ||
| "webfontloader": "1.6.28", | ||
| "zod": "^3.25.76" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/plugin-proposal-private-property-in-object": "7.21.11", | ||
|
|
@@ -212,4 +217,4 @@ | |
| "resolutions": { | ||
| "styled-components": "6.1.1" | ||
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| #root { | ||
| max-width: 1280px; | ||
| margin: 0 auto; | ||
| padding: 2rem; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .logo { | ||
| height: 6em; | ||
| padding: 1.5em; | ||
| will-change: filter; | ||
| transition: filter 300ms; | ||
| } | ||
| .logo:hover { | ||
| filter: drop-shadow(0 0 2em #646cffaa); | ||
| } | ||
| .logo.react:hover { | ||
| filter: drop-shadow(0 0 2em #61dafbaa); | ||
| } | ||
|
|
||
| @keyframes logo-spin { | ||
| from { | ||
| transform: rotate(0deg); | ||
| } | ||
| to { | ||
| transform: rotate(360deg); | ||
| } | ||
| } | ||
|
|
||
| @media (prefers-reduced-motion: no-preference) { | ||
| a:nth-of-type(2) .logo { | ||
| animation: logo-spin infinite 20s linear; | ||
| } | ||
| } | ||
|
|
||
| .card { | ||
| padding: 2em; | ||
| } | ||
|
|
||
| .read-the-docs { | ||
| color: #888; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: pillarwallet/x
Length of output: 68
🏁 Script executed:
Repository: pillarwallet/x
Length of output: 886
🏁 Script executed:
Repository: pillarwallet/x
Length of output: 127
🌐 Web query:
WCAG 1.4.4 Resize text requirement pinch zoom viewport meta tag💡 Result:
Short answer: Disabling pinch/zoom via the viewport meta tag (e.g. user-scalable=no or maximum-scale less than 2 / maximum-scale=1) can cause a WCAG 1.4.4 (Resize Text, Level AA) failure because it prevents users from enlarging text up to 200%. To conform, do not block user zoom in the meta viewport and ensure your CSS/layout lets text enlarge and reflow without loss of content or functionality. [1][2][3]
Recommended fix: use a simple viewport like
and remove user-scalable / maximum-scale constraints; test zoom to 200% (or text-only resizing) on mobile and desktop and fix any clipping/overflow with responsive/CSS changes. [1][2][3]
Sources:
[1] W3C Understanding SC 1.4.4 Resize Text.
[2] W3C/ACT rule “Meta viewport allows for zoom” (checks user-scalable and maximum-scale).
[3] Guidance examples and fixes (GetWCAG / accessibility tool guidance on not disabling zoom).
Disable zoom restrictions to meet WCAG 1.4.4 (Resize Text) accessibility requirement.
The viewport meta tag with
maximum-scale=1anduser-scalable=0prevents users from zooming to 200%, violating Web Content Accessibility Guidelines Level AA. Users with visual impairments cannot enlarge text to read content.To prevent accidental zoom during trading interactions without blocking accessibility, remove the zoom restrictions and use CSS
touch-action: manipulationon specific interactive elements (buttons, sliders) to prevent double-tap zoom while preserving pinch-zoom capability:Then apply to interactive elements:
Test zoom functionality to 200% on mobile devices to confirm text enlarges without clipping.
🤖 Prompt for AI Agents