Skip to content

feat/PRO-3332/trading-view-chart #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RanaBug wants to merge 4 commits into
base: staging
Choose a base branch
from
Open

feat/PRO-3332/trading-view-chart #488

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1cd950
implementation datafeed in trading view chart
RanaBug Dec 23, 2025
aee32cd
update package.json
RanaBug Jan 5, 2026
47b9ace
fix: update charting_library URL to use HTTPS
sankhavaramsaitulasiram Jan 9, 2026
431bd91
update lock file to use https
sankhavaramsaitulasiram Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,8 @@ yarn-error.log*
# Sentry Config File
.sentryclirc
/src/apps/insights/_lovable
# TradingView Charting Library (large files, should not be committed)
/public/charting_library
/public/datafeeds
/src/charting_library
Comment on lines +33 to +36

@coderabbitai coderabbitai Bot Dec 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if charting_library package includes a datafeeds directory
fd -t d 'datafeeds' node_modules/charting_library 2>/dev/null || echo "No datafeeds directory found in charting_library package"

# Also check the package.json for the copy-files script
echo "=== Checking copy-files script in package.json ==="
rg -A 20 'copy-files' package.json || echo "No copy-files script found"

Repository: pillarwallet/x

Length of output: 1147

Remove unnecessary /public/datafeeds ignore pattern.

The .gitignore includes /public/datafeeds, but there is no datafeeds directory in the charting_library package and the copy-files script does not create one. This entry should be removed unless a future version of the library includes it.

🤖 Prompt for AI Agents 
In .gitignore around lines 33 to 36, the entry "/public/datafeeds" is
unnecessary because no datafeeds directory is produced by the charting_library
package or the copy-files script; remove the "/public/datafeeds" line from
.gitignore and keep the other TradingView ignore entries intact so the file only
ignores existing/expected build artifacts.


220 changes: 15 additions & 205 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"test:update": "vitest -u",
"test:ci": "vitest run --coverage",
"sentry:sourcemaps": "sentry-cli sourcemaps inject --org pillar-project --project x ./build && sentry-cli sourcemaps upload --org pillar-project --project x ./build",
"postinstall": "patch-package",
"postinstall": "patch-package && npm run copy-files",
"copy-files": "cp -R node_modules/charting_library/charting_library public/ && cp -R node_modules/charting_library/charting_library src/",
"lint": "eslint 'src/**/*.{js,jsx,ts,tsx}'",
"lint:fix": "eslint 'src/**/*.{js,jsx,ts,tsx}' --fix",
"format": "prettier --write 'src/**/*.{js,jsx,ts,tsx,json,css,scss,md}'"
Expand Down Expand Up @@ -128,7 +129,8 @@
"viem": "2.37.1",
"vite-plugin-svgr": "4.3.0",
"wagmi": "2.14.16",
"webfontloader": "1.6.28"
"webfontloader": "1.6.28",
"charting_library": "git@github.com:tradingview/charting_library.git#semver:30.1.0"
},
"devDependencies": {
"@babel/plugin-proposal-private-property-in-object": "7.21.11",
Expand Down
5 changes: 5 additions & 0 deletions public/charting_library.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
export * from './charting_library/charting_library';
declare module 'charting_library/datafeeds/udf/dist/bundle' {
const UDFCompatibleDatafeed: typeof import('./datafeeds/udf/src/udf-compatible-datafeed').UDFCompatibleDatafeed;
export { UDFCompatibleDatafeed };
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
1 change: 0 additions & 1 deletion src/apps/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { AppManifest } from '../types';
* @returns AppManifest | null
*/
export const loadApp = async (app: ApiAllowedApp) => {
console.log('ateempting to load app', app);
let appManifest: AppManifest | null = null;

try {
Expand Down
Loading
Loading