Return list<mixed> from PDOStatement::fetchAll() in function signature map#5643
Open
phpstan-bot wants to merge 5 commits into
Open
Return list<mixed> from PDOStatement::fetchAll() in function signature map#5643phpstan-bot wants to merge 5 commits into
list<mixed> from PDOStatement::fetchAll() in function signature map#5643phpstan-bot wants to merge 5 commits into
Conversation
…`, and `pg_fetch_all_columns()` in function signature map - Change PDOStatement::fetchAll() return type from `array` to `list<mixed>` (PHP 8.0+) and from `array|false` to `list<mixed>|false` (pre-8.0) across all four overload variants - Change pg_fetch_all() return type from `array<non-empty-list<string|null>>` to `list<non-empty-list<string|null>>` - Change pg_fetch_all_columns() return type from `array|false` to `list<string|null>|false` - Change sqlite_fetch_all() return type from `array` to `list<mixed>` - All these functions return sequentially 0-indexed arrays, which are lists by definition - mysqli_fetch_all / mysqli_result::fetch_all were already correctly typed as `list<array>`
staabm
reviewed
May 12, 2026
The default overload variant covers all fetch modes including FETCH_KEY_PAIR and FETCH_GROUP which return associative arrays, not lists. Only the specific overload variants (FETCH_COLUMN, FETCH_CLASS, FETCH_FUNC) are guaranteed to return lists. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
staabm
requested changes
May 12, 2026
staabm
changed the title
list<mixed> from PDOStatement::fetchAll(), pg_fetch_all(), and pg_fetch_all_columns() in function signature maplist<mixed> from PDOStatement::fetchAll() in function signature map
…changes These functions should not have their return types narrowed to list: - pg_fetch_all/pg_fetch_all_columns: revert to original array types - sqlite_fetch_all: undocumented on php.net, keep as array Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
staabm
reviewed
May 12, 2026
… list Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
VincentLanglet
requested changes
May 12, 2026
Contributor
VincentLanglet
left a comment
VincentLanglet
left a comment
There was a problem hiding this comment.
$stmt->fetchAll(\PDO::FETCH_COLUMN); is a valid call and returns a list.
Since both
$stmt->fetchAll(PDO::FETCH_ASSOC)
$stmt->fetchAll(\PDO::FETCH_COLUMN);
fallback to the same signature, I think we cannot solve this by changing the functionMap, but with a dedicated returnTypeExtension instead.
The function map alone cannot distinguish single-argument calls like fetchAll(PDO::FETCH_COLUMN) from fetchAll(PDO::FETCH_ASSOC) since both match the same default signature. This extension inspects the constant fetch mode value to determine whether the result is a list or array. Modes with FETCH_GROUP/FETCH_UNIQUE flags or FETCH_KEY_PAIR return associative arrays (not lists). All other known modes return lists. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Pushed. Here's what I did to address VincentLanglet's review: Created
This solves the reviewer's concern that Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#11889