Document new key builtin_default_value of the array returned by ini_get_all() in PHP >= 8.6.0#5581
Open
sebastianbergmann wants to merge 1 commit into
Open
Document new key builtin_default_value of the array returned by ini_get_all() in PHP >= 8.6.0#5581sebastianbergmann wants to merge 1 commit into
builtin_default_value of the array returned by ini_get_all() in PHP >= 8.6.0#5581sebastianbergmann wants to merge 1 commit into
Conversation
…_get_all() in PHP >= 8.6.0
sebastianbergmann
changed the title
builtin_default_value of the array returned by ini_get_all() in PHP >= 8.6.0
jordikroon
requested changes
May 25, 2026
Member
jordikroon
left a comment
jordikroon
left a comment
There was a problem hiding this comment.
LGTM. Just a few style guide nits. Also meant to reduce the chances of a merge conflict later om.
Comment on lines
+82
to
+102
| <para> | ||
| <informaltable> | ||
| <tgroup cols="2"> | ||
| <thead> | ||
| <row> | ||
| <entry>&Version;</entry> | ||
| <entry>&Description;</entry> | ||
| </row> | ||
| </thead> | ||
| <tbody> | ||
| <row> | ||
| <entry>8.6.0</entry> | ||
| <entry> | ||
| The <literal>builtin_default_value</literal> element was added to the | ||
| details array returned for each directive. | ||
| </entry> | ||
| </row> | ||
| </tbody> | ||
| </tgroup> | ||
| </informaltable> | ||
| </para> |
Member
There was a problem hiding this comment.
Suggested change
| <para> | |
| <informaltable> | |
| <tgroup cols="2"> | |
| <thead> | |
| <row> | |
| <entry>&Version;</entry> | |
| <entry>&Description;</entry> | |
| </row> | |
| </thead> | |
| <tbody> | |
| <row> | |
| <entry>8.6.0</entry> | |
| <entry> | |
| The <literal>builtin_default_value</literal> element was added to the | |
| details array returned for each directive. | |
| </entry> | |
| </row> | |
| </tbody> | |
| </tgroup> | |
| </informaltable> | |
| </para> | |
| <informaltable> | |
| <tgroup cols="2"> | |
| <thead> | |
| <row> | |
| <entry>&Version;</entry> | |
| <entry>&Description;</entry> | |
| </row> | |
| </thead> | |
| <tbody> | |
| <row> | |
| <entry>8.6.0</entry> | |
| <entry> | |
| The <literal>builtin_default_value</literal> element was added to the | |
| details array returned for each directive. | |
| </entry> | |
| </row> | |
| </tbody> | |
| </tgroup> | |
| </informaltable> |
| Returns &false; and raises an <constant>E_WARNING</constant> level error | ||
| if the <parameter>extension</parameter> doesn't exist. | ||
| </para> | ||
| <para> |
| directive, or &null; if it has none, independent of values set in | ||
| &php.ini;, on the command line, or at runtime), and | ||
| <literal>access</literal> (the access level). | ||
| </para> |
Member
There was a problem hiding this comment.
Suggested change
| </para> | |
| </simpara> |
Member
|
This should probably wait until PHP 8.6 actually drops. |
lacatoire
reviewed
May 25, 2026
|
|
||
| <refsect1 role="returnvalues"> | ||
| &reftitle.returnvalues; | ||
| <para> |
lacatoire
reviewed
May 25, 2026
| Returns an associative array with directive name as the array key. | ||
| Returns &false; and raises an <constant>E_WARNING</constant> level error | ||
| if the <parameter>extension</parameter> doesn't exist. | ||
| </para> |
lacatoire
reviewed
May 25, 2026
Comment on lines
64
to
77
| @@ -74,6 +77,31 @@ | |||
| </note> | |||
Member
There was a problem hiding this comment.
Suggested change
| <simpara> | |
| When <parameter>details</parameter> is &false; the value will be the | |
| current value of the option. | |
| </simpara> | |
| <simpara> | |
| See the <link linkend="configuration.changes.modes">manual section</link> | |
| for information on what access levels mean. | |
| </simpara> | |
| <note> | |
| <simpara> | |
| It's possible for a directive to have multiple access levels, which is | |
| why <literal>access</literal> shows the appropriate bitmask values. | |
| </simpara> | |
| </note> |
Member
|
@lacatoire as long as those inner para's do not change. There is no need to suggest to migrate to |
Contributor
Author
This updates the documentation of |
Member
|
@sebastianbergmann there isn't really a policy, but best to wait for alpha 1 before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the documentation for
ini_get_all()after php/php-src#22134.