Unlock audio in Iphone/Ipad devices#162
Open
ps91 wants to merge 1 commit into
Open
Conversation
The unlock function wasn't working and after some research I found this solution: https://paulbakaus.com/tutorials/html5/web-audio-on-ios/ Just changed the `source.start(0)` to `source.noteOn(0)` and it worked.
Owner
|
|
Author
|
The devices I tested the noteOn() worked but the start() won't work. What should be the best approach then? |
Owner
|
Updating the devices? :) Or use a polyfill: if (source.start) {
source.start(0);
}
else {
source.noteOn(0);
}I won't merge this, though, sorry. |
Author
|
No everyone updates their devices (or even can't update), we should be careful and make the library more compatible. Thanks for the answer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unlock function wasn't working and after some research I found this solution:
https://paulbakaus.com/tutorials/html5/web-audio-on-ios/
Just changed the
source.start(0)tosource.noteOn(0)and it worked.