Skip to content

Fix likely typo in TAP assertion messages #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeltz wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −21
Open

Fix likely typo in TAP assertion messages #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions t/002_settings_pgsm_track_planning.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,30 +64,30 @@
($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT total_plan_time FROM pg_stat_monitor WHERE calls = 2;');
trim($stdout);
isnt($stdout, '0', "Compare: total_plan_time is not 0).");
isnt($stdout, '0', "Compare: total_plan_time is not 0.");

# Test: min_plan_time is not 0
($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT min_plan_time FROM pg_stat_monitor WHERE calls = 2;');
trim($stdout);
isnt($stdout, '0', "Compare: min_plan_time is not 0).");
isnt($stdout, '0', "Compare: min_plan_time is not 0.");

# Test: max_plan_time is not 0
($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT max_plan_time FROM pg_stat_monitor WHERE calls = 2;');
trim($stdout);
isnt($stdout, '0', "Compare: max_plan_time is not 0).");
isnt($stdout, '0', "Compare: max_plan_time is not 0.");

# Test: mean_plan_time is not 0
($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT mean_plan_time FROM pg_stat_monitor WHERE calls = 2;');
trim($stdout);
isnt($stdout, '0', "Compare: mean_plan_time is not 0).");
isnt($stdout, '0', "Compare: mean_plan_time is not 0.");

# Test: stddev_plan_time is not 0
#($cmdret, $stdout, $stderr) = $node->psql('postgres', 'SELECT stddev_plan_time FROM pg_stat_monitor WHERE calls = 2;');
#trim($stdout);
#isnt($stdout, '0', "Compare: stddev_plan_time is not 0).");
#isnt($stdout, '0', "Compare: stddev_plan_time is not 0.");

# Test: total_plan_time = min_plan_time + max_plan_time
($cmdret, $stdout, $stderr) = $node->psql('postgres',
Expand Down Expand Up @@ -154,31 +154,31 @@
($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT total_plan_time FROM pg_stat_monitor WHERE calls = 2;');
trim($stdout);
is($stdout, '0', "Compare: total_plan_time is 0).");
is($stdout, '0', "Compare: total_plan_time is 0.");

# Test: min_plan_time is 0
($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT min_plan_time FROM pg_stat_monitor WHERE calls = 2;');
trim($stdout);
is($stdout, '0', "Compare: min_plan_time is 0).");
is($stdout, '0', "Compare: min_plan_time is 0.");

# Test: max_plan_time is 0
($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT max_plan_time FROM pg_stat_monitor WHERE calls = 2;');
trim($stdout);
is($stdout, '0', "Compare: max_plan_time is 0).");
is($stdout, '0', "Compare: max_plan_time is 0.");

# Test: mean_plan_time is 0
($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT mean_plan_time FROM pg_stat_monitor WHERE calls = 2;');
trim($stdout);
is($stdout, '0', "Compare: mean_plan_time is 0).");
is($stdout, '0', "Compare: mean_plan_time is 0.");

# Test: stddev_plan_time is 0
($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT stddev_plan_time FROM pg_stat_monitor WHERE calls = 2;');
trim($stdout);
is($stdout, '0', "Compare: stddev_plan_time is 0).");
is($stdout, '0', "Compare: stddev_plan_time is 0.");

($cmdret, $stdout, $stderr) = $node->psql(
'postgres',
Expand Down
14 changes: 7 additions & 7 deletions t/017_execution_stats.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,38 +68,38 @@
($cmdret, $stdout, $stderr) = $node->psql('postgres',
"SELECT ${col_total_time} FROM pg_stat_monitor WHERE calls = 2;");
trim($stdout);
isnt($stdout, '0', "Compare: ${col_total_time} is not 0).");
isnt($stdout, '0', "Compare: ${col_total_time} is not 0.");

# Test: ${col_min_time} is not 0
($cmdret, $stdout, $stderr) = $node->psql('postgres',
"SELECT ${col_min_time} FROM pg_stat_monitor WHERE calls = 2;");
trim($stdout);
isnt($stdout, '0', "Compare: ${col_min_time} is not 0).");
isnt($stdout, '0', "Compare: ${col_min_time} is not 0.");

# Test: ${col_max_time} is not 0
($cmdret, $stdout, $stderr) = $node->psql('postgres',
"SELECT ${col_max_time} FROM pg_stat_monitor WHERE calls = 2;");
trim($stdout);
isnt($stdout, '0', "Compare: ${col_max_time} is not 0).");
isnt($stdout, '0', "Compare: ${col_max_time} is not 0.");

# Test: ${col_mean_time} is not 0
($cmdret, $stdout, $stderr) = $node->psql('postgres',
"SELECT ${col_mean_time} FROM pg_stat_monitor WHERE calls = 2;");
trim($stdout);
isnt($stdout, '0', "Compare: ${col_mean_time} is not 0).");
isnt($stdout, '0', "Compare: ${col_mean_time} is not 0.");

# Test: ${col_stddev_time} is not 0
#($cmdret, $stdout, $stderr) = $node->psql('postgres', "SELECT ${col_stddev_time} FROM pg_stat_monitor WHERE calls = 2;");
#trim($stdout);
#isnt($stdout, '0', "Test: ${col_stddev_time} should not be 0).");
#isnt($stdout, '0', "Test: ${col_stddev_time} should not be 0.");

# Test: ${col_total_time} = ${col_min_time} + ${col_max_time}
($cmdret, $stdout, $stderr) = $node->psql('postgres',
"SELECT (round(${col_total_time}::numeric, 3) = round(${col_min_time}::numeric + ${col_max_time}::numeric, 3)) FROM pg_stat_monitor WHERE calls = 2;"
);
trim($stdout);
is($stdout, 't',
"Compare: (round(${col_total_time}::numeric, 3) = round(${col_min_time}::numeric + ${col_max_time}::numeric, 3))."
"Compare: round(${col_total_time}::numeric, 3) = round(${col_min_time}::numeric + ${col_max_time}::numeric, 3)."
);

# Test: ${col_mean_time} = ${col_total_time}/2
Expand All @@ -110,7 +110,7 @@
# Test: ${col_stddev_time} = ${col_mean_time} - ${col_min_time}
#($cmdret, $stdout, $stderr) = $node->psql('postgres', 'SELECT round(${col_stddev_time}::numeric, 3) = round(${col_mean_time}::numeric - ${col_min_time}::numeric, 3) FROM pg_stat_monitor WHERE calls = 2;');
#trim($stdout);
#is($stdout,'t',"Compare ${col_mean_time}: round(${col_stddev_time}::numeric, 3) = round(${col_mean_time}::numeric - ${col_min_time}::numeric, 3)).");
#is($stdout,'t',"Compare ${col_mean_time}: round(${col_stddev_time}::numeric, 3) = round(${col_mean_time}::numeric - ${col_min_time}::numeric, 3).");

# Dump output to out file
($cmdret, $stdout, $stderr) = $node->psql(
Expand Down
8 changes: 4 additions & 4 deletions t/025_compare_pgss.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
'SELECT sum(pgsm.rows) = sum(pgss.rows) FROM pg_stat_monitor AS pgsm INNER JOIN pg_stat_statements AS pgss ON pgss.query = pgsm.query WHERE pgsm.query LIKE \'%DELETE FROM pgbench_accounts%\' GROUP BY pgsm.query;'
);
trim($stdout);
is($stdout, 't', "Compare: rows are equal).");
is($stdout, 't', "Compare: rows are equal.");

($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT sum(pgsm.total_exec_time) = sum(round(pgss.total_exec_time::numeric, 4)) OR sum(pgss.total_exec_time::numeric) % sum(pgsm.total_exec_time::numeric) < 1 FROM pg_stat_monitor AS pgsm INNER JOIN pg_stat_statements AS pgss ON pgss.query = pgsm.query WHERE pgsm.query LIKE \'%DELETE FROM pgbench_accounts%\' GROUP BY pgsm.query;'
Expand Down Expand Up @@ -229,7 +229,7 @@
'SELECT sum(pgsm.rows) = sum(pgss.rows) FROM pg_stat_monitor AS pgsm INNER JOIN pg_stat_statements AS pgss ON pgss.query = pgsm.query WHERE pgsm.query LIKE \'%INSERT INTO pgbench_history%\' GROUP BY pgsm.query;'
);
trim($stdout);
is($stdout, 't', "Compare: rows are equal).");
is($stdout, 't', "Compare: rows are equal.");

($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT sum(pgsm.total_exec_time) = sum(round(pgss.total_exec_time::numeric, 4)) OR sum(pgss.total_exec_time::numeric) % sum(pgsm.total_exec_time::numeric) < 1 FROM pg_stat_monitor AS pgsm INNER JOIN pg_stat_statements AS pgss ON pgss.query = pgsm.query WHERE pgsm.query LIKE \'%INSERT INTO pgbench_history%\' GROUP BY pgsm.query;'
Expand Down Expand Up @@ -323,7 +323,7 @@
'SELECT sum(pgsm.rows) = sum(pgss.rows) FROM pg_stat_monitor AS pgsm INNER JOIN pg_stat_statements AS pgss ON pgss.query = pgsm.query WHERE pgsm.query LIKE \'%SELECT abalance FROM pgbench_accounts%\' GROUP BY pgsm.query;'
);
trim($stdout);
is($stdout, 't', "Compare: rows are equal).");
is($stdout, 't', "Compare: rows are equal.");

($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT sum(pgsm.total_exec_time) = sum(round(pgss.total_exec_time::numeric, 4)) OR sum(pgss.total_exec_time::numeric) % sum(pgsm.total_exec_time::numeric) < 1 FROM pg_stat_monitor AS pgsm INNER JOIN pg_stat_statements AS pgss ON pgss.query = pgsm.query WHERE pgsm.query LIKE \'%SELECT abalance FROM pgbench_accounts%\' GROUP BY pgsm.query;'
Expand Down Expand Up @@ -417,7 +417,7 @@
'SELECT sum(pgsm.rows) = sum(pgss.rows) FROM pg_stat_monitor AS pgsm INNER JOIN pg_stat_statements AS pgss ON pgss.query = pgsm.query WHERE pgsm.query LIKE \'%UPDATE pgbench_accounts%\' GROUP BY pgsm.query;'
);
trim($stdout);
is($stdout, 't', "Compare: rows are equal).");
is($stdout, 't', "Compare: rows are equal.");

($cmdret, $stdout, $stderr) = $node->psql('postgres',
'SELECT sum(pgsm.total_exec_time) = sum(round(pgss.total_exec_time::numeric, 4)) OR sum(pgss.total_exec_time::numeric) % sum(pgsm.total_exec_time::numeric) < 1 FROM pg_stat_monitor AS pgsm INNER JOIN pg_stat_statements AS pgss ON pgss.query = pgsm.query WHERE pgsm.query LIKE \'%UPDATE pgbench_accounts%\' GROUP BY pgsm.query;'
Expand Down
Loading