K8SPG-1080 v3 module#1686
Draft
oksana-grishchenko wants to merge 1 commit into
Draft
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
35
to
+37
| python3 -m yq -r \ | ||
| .spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.customTLSSecret.properties.name.description \ | ||
| "${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml" | ||
| "${clusters_dir}/generated/upstream.pgv3.percona.com_postgresclusters.yaml" |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| python3 -m yq -r \ | |
| .spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.customTLSSecret.properties.name.description \ | |
| "${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml" | |
| "${clusters_dir}/generated/upstream.pgv3.percona.com_postgresclusters.yaml" | |
| python3 -m yq -r \ | |
| .spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.customTLSSecret.properties.name.description \ | |
| "${clusters_dir}/generated/upstream.pgv3.percona.com_postgresclusters.yaml" |
| @@ -34,7 +34,7 @@ echo "Generating Kustomize patch file for removing Kube API TODOs" | |||
| name_desc_with_todo=$( | |||
| python3 -m yq -r \ | |||
| .spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.customTLSSecret.properties.name.description \ | |||
| "${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml" | |||
| "${clusters_dir}/generated/upstream.pgv3.percona.com_postgresclusters.yaml" | |||
| ) | |||
| name_desc_without_todo=$(sed 's/ TODO.*//g' <<< "${name_desc_with_todo}") | |||
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| name_desc_without_todo=$(sed 's/ TODO.*//g' <<< "${name_desc_with_todo}") | |
| name_desc_without_todo=$(sed 's/ TODO.*//g' <<<"${name_desc_with_todo}") |
| @@ -44,11 +44,11 @@ python3 -m yq -y --arg old "${name_desc_with_todo}" --arg new "${name_desc_witho | |||
| [paths(select(. == $old)) | { op: "copy", from: "/work", path: "/\(map(tostring) | join("/"))" }] + | |||
| [{ op: "remove", path: "/work" }] | |||
| ' \ | |||
| "${clusters_dir}/generated/upstream.pgv2.percona.com_postgresclusters.yaml" > "${clusters_dir}/todos.yaml" | |||
| "${clusters_dir}/generated/upstream.pgv3.percona.com_postgresclusters.yaml" > "${clusters_dir}/todos.yaml" | |||
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| "${clusters_dir}/generated/upstream.pgv3.percona.com_postgresclusters.yaml" > "${clusters_dir}/todos.yaml" | |
| "${clusters_dir}/generated/upstream.pgv3.percona.com_postgresclusters.yaml" >"${clusters_dir}/todos.yaml" |
|
|
||
| python3 -m yq -y --arg old "${name_desc_with_todo}" --arg new "${name_desc_without_todo}" ' | ||
| [{ op: "add", path: "/work", value: $new }] + | ||
| [paths(select(. == $old)) | { op: "copy", from: "/work", path: "/\(map(tostring) | join("/"))" }] + | ||
| [{ op: "remove", path: "/work" }] | ||
| ' \ | ||
| "${upgrades_dir}/generated/upstream.pgv2.percona.com_pgupgrades.yaml" > "${upgrades_dir}/todos.yaml" | ||
| "${upgrades_dir}/generated/upstream.pgv3.percona.com_pgupgrades.yaml" > "${upgrades_dir}/todos.yaml" |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| "${upgrades_dir}/generated/upstream.pgv3.percona.com_pgupgrades.yaml" > "${upgrades_dir}/todos.yaml" | |
| "${upgrades_dir}/generated/upstream.pgv3.percona.com_pgupgrades.yaml" >"${upgrades_dir}/todos.yaml" |
| @@ -29,25 +29,25 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/manager" | |||
|
|
|||
| certmanagerscheme "github.com/cert-manager/cert-manager/pkg/client/clientset/versioned/scheme" | |||
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
| certmanagerscheme "github.com/cert-manager/cert-manager/pkg/client/clientset/versioned/scheme" |
| @@ -15,9 +15,9 @@ import ( | |||
| apierrors "k8s.io/apimachinery/pkg/api/errors" | |||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
|
|
|||
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
| "sigs.k8s.io/controller-runtime/pkg/client" | |
| @@ -20,11 +20,11 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/manager" | |||
| "sigs.k8s.io/yaml" | |||
|
|
|||
| "github.com/percona/percona-postgresql-operator/v2/internal/controller/runtime" | |||
| "github.com/percona/percona-postgresql-operator/v3/internal/controller/runtime" | |||
|
|
|||
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
| @@ -20,12 +20,12 @@ import ( | |||
| "k8s.io/apimachinery/pkg/types" | |||
| "sigs.k8s.io/controller-runtime/pkg/client" | |||
|
|
|||
| "github.com/percona/percona-postgresql-operator/v2/internal/feature" | |||
| "github.com/percona/percona-postgresql-operator/v3/internal/feature" | |||
|
|
|||
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
Comment on lines
19
to
20
| volumesnapshotv1 "github.com/kubernetes-csi/external-snapshotter/client/v8/apis/volumesnapshot/v1" | ||
|
|
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
| volumesnapshotv1 "github.com/kubernetes-csi/external-snapshotter/client/v8/apis/volumesnapshot/v1" |
| @@ -17,9 +17,9 @@ import ( | |||
|
|
|||
| "github.com/pkg/errors" | |||
|
|
|||
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
| corev1 "k8s.io/api/core/v1" | |
Comment on lines
16
to
17
| "github.com/pkg/errors" | ||
|
|
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
| "github.com/pkg/errors" |
Comment on lines
16
to
17
| "github.com/pkg/errors" | ||
|
|
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
| "github.com/pkg/errors" |
| "github.com/percona/percona-postgresql-operator/v3/internal/logging" | ||
| "github.com/percona/percona-postgresql-operator/v3/internal/naming" | ||
| v2 "github.com/percona/percona-postgresql-operator/v3/pkg/apis/pgv3.percona.com/v2" | ||
| "github.com/percona/percona-postgresql-operator/v3/pkg/apis/upstream.pgv3.percona.com/v1beta1" | ||
| "github.com/pkg/errors" |
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
| "github.com/pkg/errors" |
| @@ -21,12 +21,12 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/client/fake" | |||
|
|
|||
| volumesnapshotv1 "github.com/kubernetes-csi/external-snapshotter/client/v8/apis/volumesnapshot/v1" | |||
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
| volumesnapshotv1 "github.com/kubernetes-csi/external-snapshotter/client/v8/apis/volumesnapshot/v1" |
Collaborator
commit: 1793a01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3 module
Problem:
PG 3.0.0 is released while go module still references v2 which makes it harder to use it.
Solution:
Implement v3 module
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability