Add IAM Auth support - #326
Open
bvalente wants to merge 3 commits into
Open
Conversation
Signed-off-by: Bernardo Valente <bernardofvalente@gmail.com>
bvalente
requested review from
a team,
BupycHuk and
JiriCtvrtka
and removed request for
a team
October 20, 2025 09:03
JiriCtvrtka
approved these changes
Oct 24, 2025
Author
|
Hello @JiriCtvrtka thank you for your review. Is there a schedule or something else needed to merge the PR? 😊 |
Author
|
Hi again @JiriCtvrtka ! Would it be posible to go ahead with merging this PR? Please let me know if you need any more information or feedback. |
JiriCtvrtka
requested review from
4nte and
ademidoff
and removed request for
a team and
BupycHuk
August 19, 2026 12:31
|
@bvalente Yeah, sorry, I completely missed this one. I’m going to add some tests for the newly added fields, then ask QA whether we can proceed or if it needs to be tested manually. |
Author
|
@JiriCtvrtka Thank you for the test files. I've cherry-picked your commit into my branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to
prometheusupstream PR prometheus#983 and issue prometheus#749.We're adding the option to authenticate to AWS RDS with IAM, as described in this guide: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.IAMDBAuth.Connecting.Go.html
To test, I used the following config file (with redacted values):