feat(DTCRCMERC-4687): implement v5 text-layout styles for renderV2Message#1331
Open
sailaya99 wants to merge 3 commits into
Open
feat(DTCRCMERC-4687): implement v5 text-layout styles for renderV2Message#1331sailaya99 wants to merge 3 commits into
sailaya99 wants to merge 3 commits into
Conversation
…sage - Add body reset and scoped .pp-message stylesheet (display:block, width:100%) - Map text.color to CSS classes on .main/.action spans with vertical-align:middle - Add CSS filters on .logo img for white (invert), monochrome (grayscale+black), grayscale variants - Handle logo positions: left (default), right (margin swap), top (block display) - Implement fontSource @font-face generation with URL/name security validation - Wire fontSource through message.jsx into styles() - Add data-pp-style-* root attributes for layout, logo-type, logo-position, text-align, text-color, text-size - Add greyscale alias pipeline test (validateStyle -> render -> class) - Expand snapshot coverage to all 7 text sizes (10-16) and full logo/color/align matrix (21 snapshots)
sailaya99
requested review from
jeremy-herman,
perco12,
surekhaw and
yeul
as code owners
Braluna-pp
reviewed
Jun 11, 2026
Braluna-pp
left a comment
Braluna-pp
left a comment
Collaborator
There was a problem hiding this comment.
Thermo-nuclear code quality review: a few maintainability and coverage issues worth tightening before this lands.
- Separate logoType/logoPosition in message.jsx; buildLogoConfiguration now branches on logoType=inline without using it as a pseudo-position - Replace full-matrix snapshots with one representative render snapshot, one stylesheet snapshot, and test.each matrix assertions (119 lines vs ~1240) - Add stylesheet isolation tests (inline embed + selector scope check) - Simplify redundant selector-parsing filter in isolation test
Braluna-pp
reviewed
Jun 18, 2026
Braluna-pp
left a comment
Braluna-pp
left a comment
Collaborator
There was a problem hiding this comment.
Thermo-nuclear code-quality review: leaving three maintainability findings inline.
Braluna-pp
approved these changes
Jun 22, 2026
Braluna-pp
left a comment
Braluna-pp
left a comment
Collaborator
There was a problem hiding this comment.
LGTM thank you for addressing the feedback
surekhaw
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements v5 text-layout styles for the renderV2Message SSR module (DTCRCMERC-4687).
Previously, renderV2Message rendered with a bare .pp-message container and minimal CSS — no color treatment, no logo positioning styles, no font configuration, and no alignment support. This PR introduces a static, class-based stylesheet (no legacy mutation system) that covers all v5 text style options:
Root data-pp-style-* attributes are added to the .pp-message div for downstream observability and potential CSS hook use.