⚡ Optimize apply() nested querySelectorAll - #4
Conversation
Optimize apply() to prevent querying the DOM using querySelectorAll each time properties change. Caches the tweak buttons, their keys and values in memory at startup. Co-authored-by: pauloblikstein <931343+pauloblikstein@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: The optimization implemented creates an in-memory array
tweakButtonsthat caches the buttons that need to be updated duringapply(). The array stores the reference to the buttonbtn, thekeyit affects, and the specificvalit sets. Then,apply()simply loops over this array rather than performing recursivequerySelectorAlloperations against the live DOM on each property change.🎯 Why: Since
apply()is called every time properties change, querying the DOM from scratch usingquerySelectorAlleach time is extremely wasteful and inefficient. By caching these, we bypass expensive DOM lookups and make property application significantly faster.📊 Measured Improvement:
I created a benchmark using
jsdomto measureapply()execution time over 10,000 iterations.apply(): ~2169.17msapply(): ~289.40msPR created automatically by Jules for task 3641409870541402012 started by @pauloblikstein