Use @jtu.register_static as decorator on _Missing#1193
Draft
nstarman wants to merge 3 commits into
Draft
Conversation
Co-authored-by: nstarman <8949649+nstarman@users.noreply.github.com>
Co-authored-by: nstarman <8949649+nstarman@users.noreply.github.com>
@jtu.register_static as decorator on _Missing
Contributor
Author
|
Copilot made this PR on nstarman#3 and I transferred it here. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors how the internal _Missing sentinel type is registered with JAX pytrees by co-locating the registration directly on the class definition.
Changes:
- Apply
@jtu.register_staticas a class decorator to_Missing. - Remove the separate post-definition pytree registration call for
_Missing.
Owner
|
So I'm inclined to leave this as-is, e.g. because the older registration will work on older JAX versions. |
Contributor
Author
|
Or wait to merge until the minimum supported JAX version has |
Contributor
Author
|
I can convert back to draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies
jax.tree_util.register_staticas a class decorator on_Missinginstead of a separate post-definition call, co-locating the registration with the class.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.