BUG: fix ArrowExtensionArray construction with NaN in string data#64581
Closed
wavebyrd wants to merge 10000 commits into
Closed
BUG: fix ArrowExtensionArray construction with NaN in string data#64581wavebyrd wants to merge 10000 commits into
wavebyrd wants to merge 10000 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64578.
_box_pa_arraycallsnp.asarray(value)to build an NA mask, but when the input is a list mixing strings andnp.nan, numpy infers a unicode dtype and coerces the nan to the literal string"nan". After that,isna()returns all-False and the NaN is not masked, sopa.arrayblows up withArrowTypeError.Fix: pass
dtype=objectso the originalnp.nanstays in place andisna()can see it. This matches what theelifbranch right below already does.Added tests covering single/multiple/all-NaN and
large_string.