Feature/track subtr#68
Open
tagirahmad wants to merge 2 commits into
Open
Conversation
b5f42c7 to
83df7ea
Compare
palkan
requested changes
Oct 21, 2023
palkan
left a comment
Owner
There was a problem hiding this comment.
Thanks! We introduced some new APIs and concepts since you've opened the PR, so I would like to upgrade the implementation as follows:
- The functionality MUST be implemented as a plugin (see example).
- No need to add custom reporting, just a single configuration parameter to specify the limit (and activate the feature).
e2f0bd7 to
5ddefff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Solves issue by implementing SQL subtransactions detecting and reacting on it depending on specified configuration.
What changes did you make? (overview)
You can use feature like:
Is there anything you'd like reviewers to focus on?
Checklist