add ability to observe deadline expiration counts#94
Open
Conversation
Provides the ability to observe the number of deadline expirations that happen between two points in time. Intended for consumers to be able to potentially build more customized observability outside of the metrics reported directly by this library. A `ExpirationObservation` just reads the value of the internal meters between two points in time and exposes a count of the number of expirations that occurred.
Generate changelog in
|
bjlaub
commented
Apr 24, 2025
| } | ||
|
|
||
| @VisibleForTesting | ||
| long totalWithPropagateIntent() { |
Contributor
Author
There was a problem hiding this comment.
we could make this (or all of these) public to allow consumers to e.g. observe when a deadline expiration would throw an exception if enforcement is enabled.
Contributor
There was a problem hiding this comment.
What are your thoughts on something like #95? I think it's a bit simpler: I'm proposing we just expose the deadline metric values and provide a small utility to compute diffs between the metric value observations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides the ability to observe the number of deadline expirations that happen between two points in time. Intended for consumers to be able to potentially build more customized observability outside of the metrics reported directly by this library.
A
ExpirationObservationjust reads the value of the internal meters between two points in time and exposes a count of the number of expirations that occurred.Alternative to #92